Modernize project, migrate to PointFree Snapshot testing

WeTransfer / WeScan

Document Scanning Made Easy for iOS

MIT License

2.87k stars 564 forks source link

Modernize project, migrate to PointFree Snapshot testing #341

Closed AvdLee closed 1 year ago

AvdLee commented 2 years ago

[x] Moved away from FBSnapshotTesting, which is outdated and no longer maintained
[x] Make use of https://github.com/pointfreeco/swift-snapshot-testing instead
[x] Move example project to Example/ folder
[x] Use default SPM folder structure (Sources and Tests)
[x] Sync snapshots between CI and local runs
[x] Ignore .spm-build in Git
[x] Remove unused info.plist and WeScan.h (those were old 🦖 )
[x] Use SPM for fastlane tests instead of depending on host target & .xcodeproj file

Note: This will also be a breaking change since we no longer support iOS 12 and Swift < 5.7. Therefore, a major version bump will follow

Altogether, this should also fix CI tests ✅

wetransferplatform commented 2 years ago

	Warnings
:warning:	'init(source:)' was deprecated in iOS 12.0: Core Image Kernel Language API deprecated. (Define CI_SILENCE_GL_DEPRECATION to silence these warnings)
:warning:	'blackTranslucent' was deprecated in iOS 13.0: Use UIBarStyleBlack and set the translucent property to YES instead.
:warning:	'jpegPhotoDataRepresentation(forJPEGSampleBuffer:previewPhotoSampleBuffer:)' was deprecated in iOS 11.0
:warning:	'isAutoStillImageStabilizationEnabled' was deprecated in iOS 13.0
:warning:	'blackTranslucent' was deprecated in iOS 13.0: Use UIBarStyleBlack and set the translucent property to YES instead.
:warning:	'gray' was deprecated in iOS 13.0: renamed to 'UIActivityIndicatorView.Style.medium'

	Messages
:book:	View more details on Bitrise
:book:	WeScanTests: Executed 56 tests (0 failed, 0 retried, 0 skipped) in 19.888 seconds

Code Coverage Report

Name	Coverage
WeScan	37.45%	⚠️

Generated by :no_entry_sign: Danger Swift against 22709572a4cdc241805a3f376127a2146fdfc321

BasThomas commented 2 years ago

Could we please split this pull request up into multiple pull requests? Or is this reviewable per commit? It's a lot of changes in one go, making it hard to review and hard to revert specific changes if needed.

AvdLee commented 2 years ago

@BasThomas, I see your point, but the actual changes are minor. Most changes are moves and deletes, so reviewing should be doable. Splitting up in PRs would've been better, but I'm not sure if it would've led to a more straightforward review since the majority once again comes down to moves and deletions.

I hope it's still doable! 🙏