search

WeTransfer / WeScan

Document Scanning Made Easy for iOS
MIT License
2.86k stars 560 forks source link

Reintegrate WeScan package to Example app to make Xcode show package dependency normally #358

Closed valeriyvan closed 1 year ago

valeriyvan commented 1 year ago

Here's how Xcode shows dependency now:

Screenshot 2023-06-19 at 15 44 20

Here's how it used to show:

Screenshot 2023-06-19 at 15 38 08
wetransferplatform commented 1 year ago
Fails
:no_entry_sign: **CIRectangleDetectorTests.testCorrectlyDetectsAndReturnsQuadilateral():**
failed - Snapshot does not match reference. @− "/Users/vagrant/git/Tests/WeScanTests/__Snapshots__/CIRectangleDetectorTests/testCorrectlyDetectsAndReturnsQuadilateral.1.png" @+ "/Users/vagrant/Library/Developer/CoreSimulator/Devices/D7CA41A8-547E-4DC0-9C53-FF5A41928CA5/data/tmp/CIRectangleDetectorTests/testCorrectlyDetectsAndReturnsQuadilateral.1.png" To configure output for a custom diff tool, like Kaleidoscope: SnapshotTesting.diffTool = "ksdiff" Actual perceptual precision 0.69906247 is less than required 0.97
:no_entry_sign: **VisionRectangleDetectorTests.testCorrectlyDetectsAndReturnsQuadilateral():**
failed - Snapshot does not match reference. @− "/Users/vagrant/git/Tests/WeScanTests/__Snapshots__/VisionRectangleDetectorTests/testCorrectlyDetectsAndReturnsQuadilateral.1.png" @+ "/Users/vagrant/Library/Developer/CoreSimulator/Devices/D7CA41A8-547E-4DC0-9C53-FF5A41928CA5/data/tmp/VisionRectangleDetectorTests/testCorrectlyDetectsAndReturnsQuadilateral.1.png" To configure output for a custom diff tool, like Kaleidoscope: SnapshotTesting.diffTool = "ksdiff" Newly-taken snapshot does not match reference.
Warnings
:warning: 'gray' was deprecated in iOS 13.0: renamed to 'UIActivityIndicatorView.Style.medium'
:warning: 'blackTranslucent' was deprecated in iOS 13.0: Use UIBarStyleBlack and set the translucent property to YES instead.
:warning: 'isAutoStillImageStabilizationEnabled' was deprecated in iOS 13.0
:warning: 'jpegPhotoDataRepresentation(forJPEGSampleBuffer:previewPhotoSampleBuffer:)' was deprecated in iOS 11.0
:warning: 'init(source:)' was deprecated in iOS 12.0: Core Image Kernel Language API deprecated. (Define CI_SILENCE_GL_DEPRECATION to silence these warnings)
:warning: 'blackTranslucent' was deprecated in iOS 13.0: Use UIBarStyleBlack and set the translucent property to YES instead.
Messages
:book: WeScanTests: Executed 60 tests (2 failed, 0 retried, 0 skipped) in 16.932 seconds
:book: Slowest test: RectangleFeaturesFunnelTests/testAddAlternateImage() (5.471s)
:book: Slowest test: RectangleFeaturesFunnelTests/testAddPreviouslyDisplayedRect() (3.161s)
:book: Slowest test: RectangleFeaturesFunnelTests/testAddMinUnderThreshold() (3.046s)
:book: View more details on Bitrise

Code Coverage Report

Name Coverage
WeScan 37.76% ⚠️

Generated by :no_entry_sign: Danger Swift against 85c7eeec1b7961380f6e3d3100e8ac66e3f8ab98

AvdLee commented 1 year ago

@valeriyvan thanks for your contribution. It's actually on purpose to use the package as a local reference to ensure the example project can be used as a companion during development. It also ensures the example always uses the same version as the package inside the repository.

Therefore, I'm closing this PR as won't do.