search

WeTransfer / WeScan

Document Scanning Made Easy for iOS
MIT License
2.87k stars 561 forks source link

Compile error building package in Xcode 15.0 beta #359

Closed valeriyvan closed 1 year ago

valeriyvan commented 1 year ago

Stored properties cannot be marked unavailable with '@available'

Screenshot 2023-06-19 at 16 59 00

It should be marked se deprecated instead of unavailable.

BasThomas commented 1 year ago

Thanks for this, @valeriyvan! I wonder if we should remove them altogether, given that they've been renamed for a while — we can do a major release and mention this in the upgrade notes. What do you think?

valeriyvan commented 1 year ago

Thanks for this, @valeriyvan! I wonder if we should remove them altogether, given that they've been renamed for a while — we can do a major release and mention this in the upgrade notes. What do you think?

Hi. It doesn't matter for me remove or fix properly deprecating. You better know as maintainer. What only matters for me - make project build.

BasThomas commented 1 year ago

I think we can go ahead and remove them :)

valeriyvan commented 1 year ago

Solved with #354

BasThomas commented 1 year ago

Thanks! Seems like we can consider cutting a new release now that we're ready for Xcode 15! Would you be interested in picking that up, @valeriyvan?

valeriyvan commented 1 year ago

Thanks! Seems like we can consider cutting a new release now that we're ready for Xcode 15! Would you be interested in picking that up, @valeriyvan?

No. I would firstly fix bug #356. Actually I did already fix it. But it's kind of bug which is much more difficult to write tests for fix then to fix.

BasThomas commented 1 year ago

Gotcha, thanks for bringing it up! I'm going to take a look at that, and make sure to check with you before we cut a release!

ayushineogov commented 1 year ago

I am using this library with pods, and I am still facing this errors in Xcode 15, I do not want to unlock the pod, and just remove those lines, I have tried with Package manager and working fine, Is there any solution for pods ? @BasThomas , @valeriyvan

BasThomas commented 1 year ago

No, we no longer support CocoaPods for our latest versions.