search

WeTransfer / WeScan

Document Scanning Made Easy for iOS
MIT License
2.83k stars 550 forks source link

Remove deprecated properties #360

Closed valeriyvan closed 1 year ago

valeriyvan commented 1 year ago

This solves issue #359 and #354

wetransferplatform commented 1 year ago
Fails
:no_entry_sign: **CIRectangleDetectorTests.testCorrectlyDetectsAndReturnsQuadilateral():**
failed - Snapshot does not match reference. @− "/Users/vagrant/git/Tests/WeScanTests/__Snapshots__/CIRectangleDetectorTests/testCorrectlyDetectsAndReturnsQuadilateral.1.png" @+ "/Users/vagrant/Library/Developer/CoreSimulator/Devices/D7CA41A8-547E-4DC0-9C53-FF5A41928CA5/data/tmp/CIRectangleDetectorTests/testCorrectlyDetectsAndReturnsQuadilateral.1.png" To configure output for a custom diff tool, like Kaleidoscope: SnapshotTesting.diffTool = "ksdiff" Actual perceptual precision 0.69906247 is less than required 0.97
:no_entry_sign: **VisionRectangleDetectorTests.testCorrectlyDetectsAndReturnsQuadilateral():**
failed - Snapshot does not match reference. @− "/Users/vagrant/git/Tests/WeScanTests/__Snapshots__/VisionRectangleDetectorTests/testCorrectlyDetectsAndReturnsQuadilateral.1.png" @+ "/Users/vagrant/Library/Developer/CoreSimulator/Devices/D7CA41A8-547E-4DC0-9C53-FF5A41928CA5/data/tmp/VisionRectangleDetectorTests/testCorrectlyDetectsAndReturnsQuadilateral.1.png" To configure output for a custom diff tool, like Kaleidoscope: SnapshotTesting.diffTool = "ksdiff" Newly-taken snapshot does not match reference.
Warnings
:warning: 'gray' was deprecated in iOS 13.0: renamed to 'UIActivityIndicatorView.Style.medium'
:warning: 'blackTranslucent' was deprecated in iOS 13.0: Use UIBarStyleBlack and set the translucent property to YES instead.
:warning: 'isAutoStillImageStabilizationEnabled' was deprecated in iOS 13.0
:warning: 'jpegPhotoDataRepresentation(forJPEGSampleBuffer:previewPhotoSampleBuffer:)' was deprecated in iOS 11.0
:warning: 'init(source:)' was deprecated in iOS 12.0: Core Image Kernel Language API deprecated. (Define CI_SILENCE_GL_DEPRECATION to silence these warnings)
:warning: 'blackTranslucent' was deprecated in iOS 13.0: Use UIBarStyleBlack and set the translucent property to YES instead.
Messages
:book: WeScanTests: Executed 60 tests (2 failed, 0 retried, 0 skipped) in 13.715 seconds
:book: Slowest test: RectangleFeaturesFunnelTests/testAddAlternateImage() (4.458s)
:book: Slowest test: RectangleFeaturesFunnelTests/testAddPreviouslyDisplayedRect() (3.106s)
:book: Slowest test: RectangleFeaturesFunnelTests/testAddMinUnderThreshold() (3.031s)
:book: View more details on Bitrise

Code Coverage Report

Name Coverage
WeScan 37.73% ⚠️

Generated by :no_entry_sign: Danger Swift against f9865863115a9d45303fe67c5587599fa31d9342

BasThomas commented 1 year ago

FYI @AvdLee that I suggested to remove these rather than deprecating them, given that they have been obsolete in a previous version. https://github.com/WeTransfer/WeScan/issues/359#issuecomment-1598434860

wetransferplatform commented 1 year ago

Congratulations! :tada: This was released as part of Release 3.0.0-beta.1 :rocket:

Generated by GitBuddy