WeTransfer / WeScan

Document Scanning Made Easy for iOS
MIT License
2.86k stars 560 forks source link

Reintegrate WeScan package to Example app to make Xcode show package dependency normally #361

Closed valeriyvan closed 1 year ago

valeriyvan commented 1 year ago

It's followup of PR #358.

This PR adds WeScan as dependency as local package.

Here's how project looks in Xcode now. Dependency is on the bottom of project navigator in section Package Dependencies. How it should be.

Screenshot 2023-06-21 at 23 55 56

Here's is how project looked before. WeScan package doesn't appear in Package Dependencies section. Instead it shows up before files of project itself.

246836157-e05e3f5e-bf7d-4ea5-9ef3-0ad318c90b02
wetransferplatform commented 1 year ago
Fails
:no_entry_sign: **CIRectangleDetectorTests.testCorrectlyDetectsAndReturnsQuadilateral():**
failed - Snapshot does not match reference. @− "/Users/vagrant/git/Tests/WeScanTests/__Snapshots__/CIRectangleDetectorTests/testCorrectlyDetectsAndReturnsQuadilateral.1.png" @+ "/Users/vagrant/Library/Developer/CoreSimulator/Devices/D7CA41A8-547E-4DC0-9C53-FF5A41928CA5/data/tmp/CIRectangleDetectorTests/testCorrectlyDetectsAndReturnsQuadilateral.1.png" To configure output for a custom diff tool, like Kaleidoscope: SnapshotTesting.diffTool = "ksdiff" Actual perceptual precision 0.69906247 is less than required 0.97
:no_entry_sign: **VisionRectangleDetectorTests.testCorrectlyDetectsAndReturnsQuadilateral():**
failed - Snapshot does not match reference. @− "/Users/vagrant/git/Tests/WeScanTests/__Snapshots__/VisionRectangleDetectorTests/testCorrectlyDetectsAndReturnsQuadilateral.1.png" @+ "/Users/vagrant/Library/Developer/CoreSimulator/Devices/D7CA41A8-547E-4DC0-9C53-FF5A41928CA5/data/tmp/VisionRectangleDetectorTests/testCorrectlyDetectsAndReturnsQuadilateral.1.png" To configure output for a custom diff tool, like Kaleidoscope: SnapshotTesting.diffTool = "ksdiff" Newly-taken snapshot does not match reference.
Warnings
:warning: 'gray' was deprecated in iOS 13.0: renamed to 'UIActivityIndicatorView.Style.medium'
:warning: 'blackTranslucent' was deprecated in iOS 13.0: Use UIBarStyleBlack and set the translucent property to YES instead.
:warning: 'blackTranslucent' was deprecated in iOS 13.0: Use UIBarStyleBlack and set the translucent property to YES instead.
:warning: 'isAutoStillImageStabilizationEnabled' was deprecated in iOS 13.0
:warning: 'jpegPhotoDataRepresentation(forJPEGSampleBuffer:previewPhotoSampleBuffer:)' was deprecated in iOS 11.0
:warning: 'init(source:)' was deprecated in iOS 12.0: Core Image Kernel Language API deprecated. (Define CI_SILENCE_GL_DEPRECATION to silence these warnings)
Messages
:book: WeScanTests: Executed 60 tests (2 failed, 0 retried, 0 skipped) in 12.786 seconds
:book: Slowest test: RectangleFeaturesFunnelTests/testAddAlternateImage() (4.223s)
:book: Slowest test: RectangleFeaturesFunnelTests/testAddPreviouslyDisplayedRect() (3.094s)
:book: Slowest test: RectangleFeaturesFunnelTests/testAddMinUnderThreshold() (3.017s)
:book: View more details on Bitrise

Code Coverage Report

Name Coverage
WeScan 37.76% ⚠️

Generated by :no_entry_sign: Danger Swift against 28425358af41e068fb2d4ffb3e95e867a1c6e002

BasThomas commented 1 year ago

@AvdLee closed the previous pull request as a won't do, as per this comment. Did you intend to open a new pull request?

BasThomas commented 1 year ago

Ah, I see it's added as a local package now. I'll leave this up to @AvdLee, as I'm not particularly familiar with local packages.

AvdLee commented 1 year ago

@valeriyvan This looks better, but I wonder whether editing still works. Does Xcode see this as a local package? In other words: are you able to alter the WeScan code from with the example project?

valeriyvan commented 1 year ago

@valeriyvan This looks better, but I wonder whether editing still works. Does Xcode see this as a local package? In other words: are you able to alter the WeScan code from with the example project?

Now I got your point. If this post https://developer.apple.com/documentation/xcode/editing-a-package-dependency-as-a-local-package is not obsolete, it's the only way by now adding local package dependency and make it editable.