search

WeTransfer / WeScan

Document Scanning Made Easy for iOS
MIT License
2.87k stars 564 forks source link

A little suggestion. #384

Closed JunkyTang closed 3 months ago

JunkyTang commented 4 months ago

Since this library is written in Swift, would it be more appropriate to change NSObjectProtocol to AnyObject here in the public protocol ImageScannerControllerDelegate: NSObjectProtocol?

This way, my class public class App {} can conform to your protocol.

BasThomas commented 4 months ago

Thanks for bringing this up, @JunkyTang! That sounds reasonable; I'd encourage you to open a pull request for this change!

github-actions[bot] commented 3 months ago

This issue is stale because it has been open for 30 days with no activity. Remove the Stale label or comment or this will be closed in 10 days.