Enhancement to adjust the manual crop

WeTransfer / WeScan

Document Scanning Made Easy for iOS

MIT License

2.87k stars 564 forks source link

Enhancement to adjust the manual crop #71

Closed saormart closed 4 years ago

saormart commented 6 years ago

As per request based on this topic

So would be great to add:

topCenter bottomCenter leftCenter rightCenter (Like the image) With this, the user could adjust the manual crop quickly if he wants to move the lines top down left right!

Test

julianschiavo commented 6 years ago

Hey, could you make it clearer what this would do? I don't understand why center points would help as we're scanning documents/rectangles?

saormart commented 6 years ago

The center point could help user to adjust both corners let's say at the same time! Let's say you want to move both corners (top right and bottom right) and the same time to make some adjustment, and would be great if while the user is moving it to adjust, it kind try to predict the paper / document border and kind of "adjust" to the borders or something like that!

julianschiavo commented 6 years ago

Sounds like a great idea to snap to edges! I’m not sure how easy that would be, however. What about just snap to edges on all corners rather than center points?

Sent from my iPhone

On Oct 23, 2018, at 10:07 PM, saormart notifications@github.com wrote:

The center point could help user to adjust both corners let's say at the same time! Let's say you want to move both corners (top right and bottom right) and the same time to make some adjustment, and would be great if while the user is moving it to adjust, it kind try to predict the paper / document border and kind of "adjust" to the borders or something like that!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

saormart commented 6 years ago

Sounds good too ! Need to see the user experience ! Do you know the app called "CamScanner" ? I get some ideas from this app! if you look at #61, that screenshot I made was from this app! If you want to know the user experience I'm talking about test it to see ! I like they "Magic Color" lol (have no idea how do they do it....)

julianschiavo commented 6 years ago

I’m aware of CamScanner 😃 As for the user experience, my implementation was completely seamless - you just tap a bar button and it applies the GPUImage adaptive thresholding.

Sent from my iPhone

On Oct 23, 2018, at 10:17 PM, saormart notifications@github.com wrote:

Sounds good too ! Need to see the user experience ! Do you know the app called "CamScanner" ? I get some ideas from this app! if you look at #61, that screenshot I made was from this app! If you want to know the user experience I'm talking about test it to see ! I like they "Magic Color" lol (have no idea how do they do it....)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

github-actions[bot] commented 4 years ago

This issue is stale because it has been open for 30 days with no activity. Remove the Stale label or comment or this will be closed in 10 days.