WeTransfer / Xperiments

Simple A/B testing tool. Includes CMS and an experimentation engine.
BSD 2-Clause "Simplified" License
4 stars 2 forks source link

Remove CORS allowed origins regex from prod config #76

Open martijnvermaat opened 7 years ago

martijnvermaat commented 7 years ago

config/prod.exs has allowed origins for our production systems hardcoded. We should make this configurable at runtime with an environment variable.

Perhaps the regex object can be created at runtime from a string?

Or we can update the CORS library to accept a simple domains with wildcards?

dsnipe commented 6 years ago

To implement this, we need to use an additional configuration plugin, something like: https://github.com/mrluc/deferred_config When I implement it, we could extract some variables to ENVs.