Add the option stringify_keys to #as_json

WeTransfer / format_parser

file metadata parsing, done cheap

https://rubygems.org/gems/format_parser

Other

62 stars 18 forks source link

Add the option stringify_keys to #as_json #153

Closed fabioperrella closed 4 years ago

fabioperrella commented 4 years ago

Hi folks! This is my 1st PR in this project.

If I did something wrong, please tell me!!

Motivation

fix #151

Proposal

Add HashUtils.deep_transform_keys copied from the activesupport source code

I chose to not add activesupport as a dependency because it is good to have the least number of dependencies!

Use HashUtils.deep_transform_keys to transform all the keys of the hash generated by as_json to a String

I chose to add the option stringify_keys on #as_json for backward compatibility. I also added info about it on README

martijnvermaat commented 4 years ago

The Travis tests fail because pry-byebug depends on Ruby 2.4. I suggest to separate the pry-byebug and example_status_persistence_file_path changes into separate PRs so they can be discussed and possibly merged independently.

fabioperrella commented 4 years ago

The Travis tests fail because pry-byebug depends on Ruby 2.4. I suggest to separate the pry-byebug and example_status_persistence_file_path changes into separate PRs so they can be discussed and possibly merged independently.

@martijnvermaat done! I will create another PR with these commits

fabioperrella commented 4 years ago

tks @julik for all the comments!!

julik commented 4 years ago

🎩 My pleasure! Will approve once tests are green

fabioperrella commented 4 years ago

🎩 My pleasure! Will approve once tests are green

I messed up a test! Now that I fixed it, it will be green! :)