WeTransfer / format_parser

file metadata parsing, done cheap
https://rubygems.org/gems/format_parser
Other
62 stars 18 forks source link

MP3: add suport to id3 v2.4.x #169

Closed fabioperrella closed 4 years ago

fabioperrella commented 4 years ago

fix #168

Proposal

Add support for MP3 files with id3 tag version 2.4.x

Refactoring in constant ID3V2_MINOR_TAG_VERSIONS to be easier to understand the values, given the byte notation is a bit hard to understand.

Comment

I'm not sure why we support the version 2.67 beucase it does not exist. I tried to remove it, but it broke 2 tests. Maybe @julik knows why

julik commented 4 years ago

No idea, need to dive into it still

On 25 Sep 2020, at 17:21, Fabio Perrella notifications@github.com wrote:

@julik could you help with that pls? do you know the reason of this number 67?