Use local image for rails test instead of remote

WeTransfer / format_parser

file metadata parsing, done cheap

https://rubygems.org/gems/format_parser

Other

62 stars 18 forks source link

Use local image for rails test instead of remote #199

Closed lao closed 2 years ago

lao commented 2 years ago

One of the tests was linked to this image ( https://freesvg.org/img/1416155153.png ), which apparently used to be of dimensions 500x296 and now it is 600x600 that is why some tests are breaking.

Changed to local image, and changed dimensions.

grdw commented 2 years ago

How can a change to this image cause a JSON parser error down the line in Ruby 2.3.0? 🤔. That's a bit random, isn't it?

lao commented 2 years ago

@grdw that error in ruby 2.3.0 is happening due to some weird behaviour (which I cannot reproduce locally at all), not caused my this PR, but also we were discussing about dropping support to version 2.3.0 until 2.5.0.