search

WeakAuras / WeakAuras-Companion

A cross-platform application built to provide the missing link between Wago.io and World of Warcraft
https://weakauras.wtf
GNU General Public License v2.0
152 stars 49 forks source link

Regression: Update check on start no longer works #886

Closed Stanzilla closed 3 years ago

Stanzilla commented 3 years ago

Operating System:

Companion Version:

3.1.1

Companion App Console Log:

Press Ctrl+Shift+I to open the console and copy-paste everything here

WeakAuras Version:

3.1.2

WeakAuras Errors:

1. Install https://mods.curse.com/addons/wow/BugSack
2. Install https://mods.curse.com/addons/wow/bug-grabber
3. Try to do whatever it is you're having a problem with again
4. Check your minimap for an icon that looks like a bag.  Is it green, or is it red?
   • GREEN
      • WeakAuras is working correctly.
      • Either you found a behavioral bug, or you are just doing it wrong :)
      • Explain the steps you took, and we will try to figure out what happened.
   • RED 
     • There are error messages. Click on the red bag to see them.
     • Copy & Paste here all of the error messages (there may be more than one, click the 'previous' button on the dialog to see previous ones

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Start app
  2. Let initial check finish
  3. Click refresh
  4. See error

Expected behavior The initial check on app start does not find aura updates, manually pressing refresh does

Screenshots If applicable, add screenshots to help explain your problem.

Include a .zip file containing: %programfiles%\World of Warcraft\_retail_\WTF\Account\<AccountName>\SavedVariables\WeakAuras.lua AND %appdata%\weakauras-companion\config.json

mrbuds commented 3 years ago

Error is Uncaught TypeError: err is not a function at this line https://github.com/WeakAuras/WeakAuras-Companion/blob/e36b18d0b20d8e078eccc8dde997f9831a4ecf3d/src/components/libs/utilities.js#L59

bentsku commented 3 years ago

Error is Uncaught TypeError: err is not a function at this line https://github.com/WeakAuras/WeakAuras-Companion/blob/e36b18d0b20d8e078eccc8dde997f9831a4ecf3d/src/components/libs/utilities.js#L59

I think the error comes from the fact that err is re-assigned. The second argument of the promise should be reject and not err. We re-reference with the err of the fs call. I think you could rename the second argument of the promise reject and reject the promise instead of done(false). I don't understand how we regressed on this one ?

mrbuds commented 3 years ago

Issue happen when you don't have Plater or WeakAuras installed

bentsku commented 3 years ago

Ha right it was the fix that created the addon folder if you didn't have it. Thanks!