Closed Causese closed 5 years ago
I really dislike having to maintain a hardcoded list. Thusunless there's a way to automatically generate such a list, I don't think we would add this.
Agreed
Couple random ideas on this:
GetInstanceInfo()
, build a local-to-client list, over time as the player enters new dungeons.i think it's doable, from something caucese did to get list of last tier zone group id
print("####")
EJ_SelectTier(EJ_GetNumTiers())
local raid = false
local instance_index = 1
local name
local instance_id
local instances = {}
local instances_mapID = {}
local instances_groupMapID = {}
repeat
instance_id = EJ_GetInstanceByIndex(instance_index, raid)
instance_index = instance_index + 1
if instance_id then
EJ_SelectInstance(instance_id)
local iname,_,_, _,_,_,dungeonAreaMapID = EJ_GetInstanceInfo();
instances_mapID[dungeonAreaMapID] = iname
local mapGroupId = C_Map.GetMapGroupID(dungeonAreaMapID)
if mapGroupId then
instances_groupMapID[mapGroupId] = iname
end
end
until not instance_id
print("* map ids: *")
for k,v in pairs(instances_mapID) do
print(k,v)
end
print("* group map ids: *")
for k,v in pairs(instances_groupMapID) do
if v ~= true then
print(k,v)
end
end
Iterating over all map ids and checking if anything has the same name as the dungeon? That doesn't feel very good to me.
i have updated the algorithm to not iterate over all ids
Right, that's much better and somewhat on par with get_encounters_list()
Is your feature request related to a problem? Please describe. To provide zone ID / zone group IDs easier to users similar to how it's done for encounterIDs
Describe the solution you'd like Simply adding these to either the zone Id / zone group Id tooltip:
Zone ID(s)
Dungeons Freehold: 936 Kings' Rest: 1004 Siege of Boralus: 1162 The MOTHERLODE!!: 1010
Zone Group ID(s)
Raids Uldir: 384 Battle of Dazar'alor: 396 Crucible of Storms: 393
Dungeons Atal'Dazar: 275 Shrine of the Storm: 281 Temple of Sethraliss: 283 The Underrot: 282 Tol Dagor: 277 Waycrest Manor: 279