WeakAuras / WeakAuras2

World of Warcraft addon that provides a powerful framework to display customizable graphics on your screen.
https://weakauras.wtf
GNU General Public License v2.0
1.29k stars 317 forks source link

Improve custom code error handling #1208

Closed emptyrivers closed 2 years ago

emptyrivers commented 5 years ago

Is your feature request related to a problem? Please describe.

When custom code has an error, the error message given to the standard error handler isn’t very descriptive of which code block ran into an error. If you aren’t familiar with the kinds of stack traces you get, you might not know exactly where things went wrong.

Describe the solution you'd like Since we wrap every custom script in xpcall, we can do whatever we like with the error message. We could add an “error cache” to WeakAuras (along the lines of what bugsack does, but individual to each script). We could direct users to contact the authors of the specific aura about the error they encountered, we could open Options to the specific line which had an error, even. There are lots of possibilities.

Describe alternatives you've considered

I haven’t really considered much yet, I just want to get this thought out of my brain and somewhere where others can contribute.

oratory commented 5 years ago

It would be slick if the Companion could track and record errors, with the option to submit to Wago. Wago could then add an "Error reports" panel and alert the aura's author.

cont1nuity commented 5 years ago

Having (semi) automatic bug reports to the authors is a dangerous thing in my opinion. Imagine someone has had their way with the WA and change the code by just a bit and it fired errors constantly. As a developer, I would not accept that bug report. Or at least I would want to know in detail what was changed. In this case it would be necessary to to track changes made to the WA and only hand in reports if the WA (code, usually) was not changed. In genereal this is a nice idea, though. But I think it should be opt-in as dev/creator on wago to prevent spamming.

emptyrivers commented 5 years ago

As it happens, we do have a feature request to track what has changed since the last import (or at least, to persist the original version), and I intend to implement that request eventually.

Heckate commented 4 years ago

Sorry but I am not a coder - just a user and student of medicine- I repeatedly get undefined error in the companion and even in the addon- unable to install 'quaking assist' (WoW BFA 8.3) - am considering deleting & finding/installing manually- but is there is there a fix already or a better notion of how to ? (sorry - forgot to mention it is 'undefined..'

mrbuds commented 4 years ago

@Heckate Hi, your problem is not related to this ticket, and the description you do doesn't allow us to help you, please come on discord at https://discord.gg/wa2 and explain with more details your issue(s).

InfusOnWoW commented 2 years ago

This is now more or less done.