WeakAuras / WeakAuras2

World of Warcraft addon that provides a powerful framework to display customizable graphics on your screen.
https://weakauras.wtf
GNU General Public License v2.0
1.27k stars 311 forks source link

Default Trigger for the Kyrian (covenant) proc doesn't work #2931

Closed StoRmBinD closed 3 years ago

StoRmBinD commented 3 years ago

Describe the bug

When trying to use default triggers to show the cooldown progress of the Kyrian covenant stun-proc (Mikanikos-NPC) the default trigger doesn't seem to fire on the event "SPELL_UPDATE_COOLDOWN" in this case.

Here is my aura with the default trigger: https://wago.io/N6buJ9trX Note: I tested with the spellIDs (331612) and (332423).

I made a custom code to double check on this and my TSU worked, see below.

Do you have an error log of what happened?

-- SPELL_UPDATE_COOLDOWN
function(states)
    local _, _, _, _, _, _, spell = GetSpellInfo(332423)
    if spell then 
        local s, d = GetSpellCooldown(332423) 
        s, d = s or 0, d or 0
        local exp, dur, icon
        if s + d then    
            exp, dur, icon = s + d, d, GetSpellTexture(332423)
        end
        states[""] = {
            show = true,
            changed = true,
            icon = icon,
            progressType = "timed", 
            duration = dur,
            expirationTime = exp,
            autoHide = false,
        }
        return true
    end
end

To Reproduce

Steps to reproduce the behavior:

Since the issue has already been explained you can reproduce it by trying the linked WeakAura from wago: https://wago.io/N6buJ9trX Note that a Kyrian with at least "Renown 30" is necessary to reproduce this ingame, since it's then when the player gets access to the proc.

Screenshots It won't help much, but this is the outcome when you compare both approaches: https://prnt.sc/z3vv7g

Did you try having WeakAuras as the only enabled addon and everything else (especially something like ElvUI) disabled? I'm pretty sure it has nothing to do with other addons. Why would my code work then.

Which version of WeakAuras are you using? WeakAuras 3.1.9

Are you on World of Warcraft Classic or Retail?

Was it working in a previous version? If yes, which was the last good one? Since I came up just now with the idea to build this there aren't any older versions of WA that can testify a possible functionality.

Additional Info

Before I opened this ticket I have discussed this issue with the moderator asakawa on the discord who advised me to come here to report it.

InfusOnWoW commented 3 years ago

The trigger works fine with the extra options:

InfusOnWoW commented 3 years ago

332423 is the right spell id.