search

WeakAuras / WeakAuras2

World of Warcraft addon that provides a powerful framework to display customizable graphics on your screen.
https://weakauras.wtf
GNU General Public License v2.0
1.31k stars 318 forks source link

Login error #4976

Closed mrbuds closed 7 months ago

mrbuds commented 7 months ago

Is there an existing issue for this?

Description

After report on discord that this https://github.com/WeakAuras/WeakAuras2/commit/6334101a3589d157b31c0c710a1af5ac70d6001e change is causing right click menu to break, i tried and get the following error on login

And indeed after reverting the commit myself the error is gone

WeakAuras Version

dev

World of Warcraft Flavor

Beta (WoW 11.0)

World of Warcraft Region

EU

Tested with only WeakAuras

I got this issue with only WeakAuras enabled

Lua Error

2x ...Ons/Blizzard_Options_Frame/OptionsFrameTemplates.lua:129: attempt to concatenate a nil value
[string "@Interface/AddOns/Blizzard_Options_Frame/OptionsFrameTemplates.lua"]:129: in function `OptionsListButton_OnLoad'
[string "*OptionsFrameTemplates.xml:201_OnLoad"]:1: in function <[string "*OptionsFrameTemplates.xml:201_OnLoad"]:1>
[string "=[C]"]: in function `resume'
[string "@Interface/AddOns/WeakAuras/WeakAuras.lua"]:4338: in function <Interface/AddOns/WeakAuras/WeakAuras.lua:4321>

Locals:
self = Button {
 0 = <userdata>
 toggle = UIParentToggle {
 }
}
toggleFunc = nil
(*temporary) = <table> {
 UpdateOnBarHighlightMarksBySpell = <function> defined @Interface/AddOns/Blizzard_ActionBar/Classic/ActionButton.lua:70
 ERR_OUT_OF_CHI = "Not enough chi"
 DH_HAVOC_CORE_ABILITY_2 = "Strong melee attack that consumes Fury. If it critical strikes, some Fury is refunded."
 MultiCastActionButton6Cooldown = MultiCastActionButton6Cooldown {
 }
 SettingsSliderOptionsMixin = <table> {
 }
 GetTrainerServiceTypeFilter = <function> defined =[C]:-1
 UNIT_NAMES_COMBATLOG_TOOLTIP = "Color unit names."
 UNIT_NAMEPLATES_TYPE_TOOLTIP_3 = "This method avoids overlapping nameplates by spreading them out horizontally and vertically."
 SetTrainerServiceTypeFilter = <function> defined =[C]:-1
 LE_GAME_ERR_CHAT_RAID_RESTRICTED_TRIAL = 796
 SPELL_FAILED_CUSTOM_ERROR_71 = "This partygoer wants to dance with you."
 LE_GAME_ERR_PET_SPELL_TARGETS_DEAD = 412
 ERROR_CLUB_TICKET_COUNT_AT_MAX_COMMUNITY = "Can't create any more invite links for this group."
 CompactUnitFrameProfilesGeneralOptionsFrameHealthTextDropdownButtonNormalTexture = CompactUnitFrameProfilesGeneralOptionsFrameHealthTextDropdownButtonNormalTexture {
 }
 MultiCastActionButton2Cooldown = MultiCastActionButton2Cooldown {
 }
 ERR_TRADE_EQUIPPED_BAG = "You can't trade equipped bags."
 PVP_RANK_6_1 = "Corporal"
 MultiBarLeftButton7 = MultiBarLeftButton7 {
 }
 InterfaceOptionsNamesPanelUnitNameplatesShowAll = InterfaceOptionsNamesPanelUnitNameplatesShowAll {
 }
 VideoOptionsFrameDefaults = VideoOptionsFrameDefaults {
 }
 MerchantItem1AltCurrencyFrameItem1Text = MerchantItem1AltCurrencyFrameItem1Text {
 }
 OPTION_TOOLTIP_ACTION_BUTTON_USE_KEY_DOWN = "Action button keybinds will respond on key down, rather than on key up."
 BINDING_NAME_NAMEPLATES = "Show Enemy Name Plates"
 INSTANCE_UNAVAILABLE_OTHER_TEMPORARILY_DISABLED = "%s cannot enter. This instance is temporarily disabled."
 MultiBarBottomRightButton8Shine5 = MultiBarBottomRightButton8Shine5 {
 }
 MAIL_LETTER_TOOLTIP = "Click to make a permanent
copy of this letter."
 UnitFrameManaBar_UnregisterDefaultEvents = <function> defined @Interface/AddOns/Blizzard_UnitFrame/Classic/UnitFrame.lua:623
 ERR_NOAMMO_S = "%s"
 CHAT_CONFIG_OTHER_COMBAT = <table> {
 }
 PlayerTalentFramePanel3Talent25 = PlayerTalentFramePanel3Talent25 {
 }
 CONSOLIDATED_BUFFS_PER_ROW = 4
 BOOST2_WARRIOR_COLOSSUSSMASH = "Use |cFFFFFFFFColossus Smash|r.

|cFFFFFFFFColossus Smash|r increases your damage."
 BN_UNABLE_TO_RESOLVE_NAME = "Unable to whisper '%s'. Blizzard services may be unavailable."
 AutoCompleteEditBox_OnKeyDown = <function> defined @Interface/AddOns/Blizzard_AutoComplete/Classic/AutoComplete.lua:368
 CompactRaidFrameManagerDisplayFrameHiddenModeToggleTopRight = CompactRaidFrameManagerDisplayFrameHiddenModeToggleTopRight {
 }
 LFGTeleport = <function> defined =[C]:-1
 LE_GAME_ERR_ONLY_ONE_QUIVER = 33
 INT_SPELL_DURATION_HOURS = "%d |4hour:hrs;"
 UnitPopupWhisperButtonMixin = <table> {
 }
 Graphics_QualityText = Graphics_QualityText {
 }
 OverrideActionBarButton6Shine11 = OverrideActionBarButton6Shine11 {
 }
 ROGUE_COMBAT_CORE_ABILITY_4 = "Melee ability with an increased range that consumes Combo Points."
 JoinSkirmish = <function> defined =[C]:-1
 Advanced_GraphicsAPIDropDownButtonHighlightTexture = Advanced_GraphicsAPIDropDownButtonHighlightTexture {
 }
 MultiBarRightButton7Shine9 = MultiBarRightButton7Shine9 {
 }
 BankFrameItem17SearchOverlay = BankFrameItem17SearchOverlay {
 }
 DMG_LCD = "DMG"
 VideoOptionsPanel_Cancel = <function> defined @Interface/AddOns/Blizzard_VideoOptions_Shared/VideoOptionsPanels.lua:327
 PetPaperDollFrameTab3Right = PetPaperDollFrameTab3Right {
 }
 Is64BitClient = <function> defined =[C]:-1
 SecureCmdItemParse = <function> defined @Interface/AddOns/Blizzard_ChatFrameBase/Classic/ChatFrame.lua:1147
 SLASH_STOPATTACK1 = "/stopattack"
 MultiCastActionButton4HotKey = MultiCastActionButton4HotKey {
 }
 CompactRaidFrameManagerDisplayFrameFilterOptionsFilterRoleTankMiddleMiddle = CompactRaidFrameManagerDisplayFrameFilterOptionsF

Reproduction Steps

login > error

Last Good Version

No response

Screenshots

No response

Export String

No response

Bisector Report

No response

emptyrivers commented 7 months ago

https://github.com/Gethe/wow-ui-source/blob/4c9ba575762cd320b8bc60161ac4cdfff5f65d61/Interface/AddOns/Blizzard_Options_Frame/OptionsFrameTemplates.lua#L128-L136 looks like we can't use this template on a nameless frame, yeah