WeakAuras / WeakAuras2

World of Warcraft addon that provides a powerful framework to display customizable graphics on your screen.
https://weakauras.wtf
GNU General Public License v2.0
1.29k stars 317 forks source link

`unit` being a player name on alpha does not work as expected #5157

Closed m33shoq closed 4 months ago

m33shoq commented 4 months ago

Is there an existing issue for this?

Description

I have a WeakAura with TSU trigger that has unit as player name, the unit is Ambiguated name that is payload from CHAT_MSG_ADDON and is used to call WA_GetUnitAura that return proper values, glow is configured through actions and it doesn't work althought sound that is also configured through actions plays correctly.

On retail the frame glows immediatly, on beta it was randomly glowing once but usually it doesnt glow at all

Exported WA is configured to glow a frame whenever player with debuff that is applied from Manifestation of Pride presses macro: /run local i = LibStub("AceComm-3.0", true);if i then i:SendCommMessage("RG_INFERNO", "GOT IT", "RAID") end

WeakAuras Version

5-13.2-40-gddfe304

World of Warcraft Flavor

Retail (Default)

World of Warcraft Region

US/NA

Tested with only WeakAuras

I got this issue with only WeakAuras enabled

Lua Error

No response

Reproduction Steps

  1. Go to zone in front of Siege of Ogrimmar entrance
  2. Find Manefistation of Pride
  3. Let it apply a Sha Corruption on you
  4. Press the macro

Last Good Version

Works on retail

Screenshots

No response

Export String

!WA:2!nE1wVnUXv4iyGeaHI0u3wJTT5HbAbwBNiR12RTl2aSPquMYwf6wPOwVnDxqpKCi5utrYoZqBPTOV4STnpBG2Fa(5wGc9tipKNjwe0Fa(L8(I(uFQNziLVR2s4lZLVZzox(MdpSuZfhTO7IUF1NYItfH0icR3qZ2T6QBFc2pU1UNTZxmU)RxFRH9Elpa7gFYVUNNhNi(43BkoYjiM1pMgjSBO31u3ib5s5jH4jMKXclVy2iSWkXsqhrkMvk5JCs5I4rsedtCXcIb5ysKyZuwyYhhiej8p7XpwE21OXp(Yd)XBVod7iOXr8Dm4cmt8pp3pm(elN4Wy2VCb45c1Cra15OicN3FHnQT9u1A5cQXdIpjxiPFY)XN5gBLBmbmyOCNdplxjtsiA9zXo5YBhZCjSGtbq840i3dFNAzpgg8lj2Zg2TLztJ6D0ViLtSUYWo0qjqYATIeeMh2H8Y6UUGt8Y(HGRZEPA7zZq7tf1I99VOq9KFxkjYzs)fwV222E0ikpyPlcOUelCyO6u4hQbllEKDUFmU0x1WQraw0kYlUMbXNYb1QoXoqib7t6ZiE0XRuPr9Hd0hOBTBRb91Bxz1Y4ug2IeDCn5atWNqpdTYLl6eh5r9V2EpdTbch5IQSFDJonhcAafZ(VlWMfcO3UVsGYxDMjkRcoXkg7z1QBtDJU9QGwBTo1FbAJDqnGdPEdGFnO8ARzOBo0O7aekkgY1r(iQhQq(phaFneE4qorUTiognchnPahHJcWhtq2eseIveKiUOv(8T3yZvlhg7Gdr8uhhiKb20)Fr0B5lRM9Jo8ubJ67ty8p8rSIHFJMKUK9Wl4P2kA)Gupa9uRg1hyAnWSUHzw5ZBepYglqTJ91sHSRT8gfHzeb0nE5Sho(9x3lnsXPxbicWTbbHxfP0xvuTA1wTmcEahxTKm2xPrVoA1nTA3Bpl9Nd3vTg2TzR2qivF3kirajsjI8j39LxzbfpkPkejS1ZvTK61aldaWQXPmhYEdBT7SXDbZB24MHyF(SjgyQBXcUGsZLrokxc5ORT91qZtiHHsWwvTQIUgXe8XlTxWnNzHkpvYNBBvFOrDld9o9Eo4GxIvsaluQe7TzRZ26gXJRIjQanC6xgZ)nZCNxDd0slsb9o6r(O2QMSweOkffDoqCcWr(aT8zibl9UGyerkl6U7rIClF7Xe4uUjDyFGm0zWEw13D3EDROcmqq9(ycJ4(vrcOADvK0IIiHqIbumuU6ojcaBU6Vz1L84EUmYHf6rb1OElGbc1oUupfk52fhKckndLu71Ze1YSYvcnNuM8kdyM1hzt9tHG6k5wrvufibWevw92joLa3BElxHwvV6hxWcLxcHREJtO5JnPQd8G6w7redHlV1bqRePi6ZHUDTnMrXx9oNoyAZoU7SNmYCll4E9a5tcdEBDU9CP5Ftzx9EL7koV0PKCELsw9vGZ(7Vxjue5CwUKJwDUGUjpF(4syX(mOMBrnGkYsuUvMp(z(hG9sxDUGVtg8MlmFbXPI49H6I)pnFzLCaKmQDVy(d37QZ7w(TVPp3B(W)HFpnNR5YlpnVtbvBltvP008UWCciohLv(Y3mL)Endv508v4jl3OT(Wp7UvyRIUzbLZDj2Wl2KzkwX77plnQ4DGLt(bYgYoMyMpVtSl5V9Ej)S7T1X8bgQC97OYMOIWHphENkKy(lNEc0y2bmCYPhumqZlosK8rnz0xJ(vPyxidIrMMSJZLGCo4DYxIdDG9txkB53ctTXoh5ZKTHPfgJD9ENSdoOTlyf40OUb2cCi49lzmknuqlp9A7PT5t34PgoHyoFPS9lRbrzN8b0xtKdovApdGj)e783fAthLafEk6L(f59sVW5mLnjJxAYACSj5Bu6cj9ccauNdOUIaT6W0ZLTW4QM)MV3BbaqLSEjQwJ)K)A2Y2rPJSjmg4g7s4obBocp(bFFTFHg8E7KfmorkNQJYnhrJkT5rKjSIcrqtUEyWhFW7F0)wtYtZo8yqFCsiXryFmomLW)e7D11g2SPM8pz4fYSptwHdjn9SViiZ60z1WYEL6uode3l)Be06zA2RtYdN)3iaL6DOYe1ctVgOlqBC9h78YNpk7Whu6F5KfSaBCr0I9BbUn1BIwB9MMNlIDks7pO0F)FuH6MS86BJKTxOAChj7FgbLhgHDyXOHrWLb7qc6aIn4YJarT3O26126PtvWhiKCPF47Y)ONMYLKEP9Ggg66DnU6Zq2mL6oTt99F6pFWX7y8KTs(057VUtGWm1b(OfOWwqCO7KVMmMjAd9ynysKZkKVu)7MMtvAOoGsLkTW5G)7sv57YtPr5AeMT0uyOdr1je)WZWr0813j7dB(1emx6cKiFrWhKTSweCz4TZklQkgW4ePI5NkHQsGVrBeMg98SLZEt2Fg(9l)GS)y2FYgssqW(CCysaUFk0zrgQPCpjmyFj0f5jlUDTnEsTnxBR1xZ311J8K13AXJ)2x8F(d

Bisector Report

No response

m33shoq commented 4 months ago

Updated export string

mrbuds commented 4 months ago

There is too much steps with this custom coded aura that could be wrong, try make a minimal example

emptyrivers commented 4 months ago
local name = Ambiguate(sender, "short")
if name then
    local _, _, _, _, duration, expirationTime = WA_GetUnitAura(name, aura_env.config.spellID, aura_env.auraType)
    if duration
    and expirationTime then
        print(name,duration,expirationTime)
        allstates[UnitGUID(name)] = {
            show = true,
            changed = true,
            progressType = "timed",
            duration = duration,
            expirationTime = expirationTime,
            autoHide = true,
            unit = name
        }
        return true
    end
end

names are generally not reliable as unit tokens, which is what state.unit expects. Since you're using the combat log events, you have access to a GUID. Consider using UnitTokenFromGUID instead (also not exactly reliable, but it might help).

m33shoq commented 4 months ago

Minimal example:

!WA:2!nA13VTrsD8ASupKb6vcIOcCN0GrQxsRJBIBte9KURYRZ6edXXM12TLJI2m7UZU7q2DMLzMnjUiEjxbUh4Pib6Eopdsi)xa6EaXJRQqiEoVW7v8epX3zw30eAlIvkoZmF)189Z3Fnv6Uq6cble8z3wWZvjugrmyY4D6TRT3H4iEVnpzJp5OHpD17nzWZX5QyUyqMIYzYB97TutZiES8upIqKljBsK(XTsXhDJ316bwsfjRQZH0av8WQR2C9wPuwLw7tMkKzKKKEBkciH48e1nU6()BlgoLuCTdkUQNKKq8vfVBvVdWj5e5T8202As3Uw6FkU(jTZfy0yWYfF54IV2XyyRz3xXyLSBhqLzj4PJjhPCd5IuSYnZvrtjUbtbRq9DvXcImMNemvmDqyOKOQmdZ8bxBiNYuEDS3DSTtg6TRPYDvYUUFUuXt1CmjlaRioKdim1zaqXbgO(ps7(wTHTcSVb22WrQWc1F)0Oe(HU(8eU4hS9d(RF(N)NVYvQS9d(hLlQw9mdDvm1FFgrkhwDTMRpZCwPISap4WsLOdAYV5jbC3YRtCPSHcYppNW8NAaMtk1hGuwdfC)sv5XHGGi(yqujpNfS3lMljenm8EYKD7nURt7(2Nbby3xDN3ZXiq2k9ykIie7tEs7GaW)EYWeahepXq(L7qBtvn5rrcWqADSNxiLrLXlEwmnG4Itsmhl3ZcowDtVs)4OkFwh3oXyvpwiVPdjIc5ucJz6dqcoImuqcPhTu9oTNmYEKT7M9gn0EN6lxtNv4syh08LPhOpcT05h6ZzH0Olq7JqRHWSau9TB70V7eqdiU4)TaTMlG9odncu7v2mZCRalw3zl3E7212z3b1rRSs)2pgT2gOoGrA3bYWgvBLvCShpXz3rieJdXAweIgIMl)hdmFbocXjsIMSIZrPy2058rKOy8beKhHWqI5GejaT0hV(ATwUwc3hNGK5((aKb3P))q0)lFz5IpyVJvcAueriV2nfZx(xkUAXgNjZ9mz9JYdbwN52P9OXUJg32zCX7FAhEQhwH2HhzLdHwpDbfr4Ol3L1k24OV0VnmNzsOxcYcGsdfr2az0xduZMnxUgc(m)aUU5Cn6xhaXXU9hTLB7n3CWU1nbdGDKkMWmCR)k99uzudKckrBG8JXmgjPbssyqIpahGmNZoyaGxJ6VyGtRAT4gcBnymQ346x2oVYwA)c0A7upAuo4llvAOg1zCgP(YVbjIYPbGetaWzRj92CjTgUmFzcOPK58gAMVmXZbTFIM2pf00V4s01F6ofabLiN041iQHKisWBLEMGhbTlLZlIQR7)fu)15laYy0HrGN1FDQKJYOL0htni0weLE1slJU9BIFDd0THwdV1RLozciQrLlr7xEPDcIkxWmQ4sNF(gi6u7L)h(RmrwM9bD2XEYhQ7LSJB7joTDDS7p4H2B2aD58UzLnQmTkNzId5LJb8Jj(7x8(NxBuww5y04XLZ)cK1onG4bfnAOvmVrYj5S5fx1Y(66o9hqgxUVppG8hUs235novQCHJj48cQULmdN8qOyfq8F3jWi1WYrBwdgpEqFRqotLD9Uc6tr)OCCaezGrQJfhuka5u4ARBoaTZ)2lwC1NdB9W(7hj090Ts44GWxOhhadxGtaJrdI9u4eWrx0jfgPtRzboP)IfFsTzxGjRw3FT774NGLsnjlj9Pe9IJ13NrWMVLhm2q4t8OPzCH65YyCa)WhxoKU6PcZDsdxw6cYJpegF9ibo74hnFrRCrs27fRuzYp8o3r)(LMu(Do)bm3z9vpv3XmWmw(zF1VGCKqTdwQgnL5Ve5tT)NZT4pU0IV3vY(EV9hbaTg9PA8Q6SlW0zO1U4Nx5OJBwCTBu5F5xSyvXrZFYH4Nb5o0WPw7y3D8PkU)C0)gv(J)P60GSBT66ihmnWmmgPhpIGQRuSVGJ6dJjtXzqzfonlHaVzkfK2BTMR28E3FMrIrkDu9B8IYh20vFKg48g1XX2E3wqZIz7)dflV)tJFS3J((oLpePk8nRec6yoOsLkvpfCHaQ5Xl1MrzLGaSBXzWsFITPKzVtW6RK(8nk(UD)ccwQVcewKk(DkUQLU)3ZFzpct9Iqs0kwESMvZl4EMvkMYEimu5zf)g4Vp9Dk(vf)ApaNb86uCswmEyomeS4UD100Sb01SUGmBH1BU2DB2AL7T6krbbHK7U69w4G)2J)pp

Macro to activate WA: /run local i = LibStub("AceComm-3.0", true);if i then i:SendCommMessage("RG_INFERNO", "GOT IT", "RAID") end

After more testing I figured out it starts glowing after wa disappears for the first time, So if I spam macro and keep updating the active state it never starts glowing, but after it disappears once the next time I press macro the glow does work correctly. This behaviour was consistent through ~10 reloads

Using UnitTokenFromGUID as rivers suggested fixes the issue