search

WeakAuras / WeakAuras2

World of Warcraft addon that provides a powerful framework to display customizable graphics on your screen.
https://weakauras.wtf
GNU General Public License v2.0
1.26k stars 309 forks source link

[Cata] Item Equipped trigger doesn't work right if you have normal + hc version of the same item #5343

Open Kolmarwow opened 3 weeks ago

Kolmarwow commented 3 weeks ago

Is there an existing issue for this?

Description

If you have normal + hc version of the same item and you try to use it in an Item Equipped trigger, it seems to only check for the normal item even if you put the heroic itemID into name field. In my case I'm testing with 359 & 372 Earthen Legplates, I noticed that if I set "Item Slot" to Legs then it works fine for both items. The Item Equipped load condition has the same problem.

WeakAuras Version

WeakAuras 5.16.1

World of Warcraft Flavor

Cataclysm Classic

World of Warcraft Region

EU

Tested with only WeakAuras

I got this issue with only WeakAuras enabled

Lua Error

No response

Reproduction Steps

  1. You need to have a normal & hc version of the same item on your character.
  2. Create an aura that uses Item - Item Equipped trigger.
  3. Put item into name field, it will only look for the normal version even if you put in the itemID of the heroic version or have normal item in bank.
  4. If you enable "Item Slot" relevant to that item then it seems to work with both versions of the item.

Last Good Version

No response

Screenshots

No response

Export String

No response

Bisector Report

No response

InfusOnWoW commented 3 weeks ago

That's because we check by name instead of by item. For spell we have extra options to check via the spell id instead of the name. For items so far, that has never been necessary to add.

Is there any reason you want to keep the normal item around?

Kolmarwow commented 3 weeks ago

In my case I use the heroic legs in DPS set & normal legs in tank OS set with different reforge/enchants/gems, as the DPS tier legs are perplexingly better statted than the tank tier legs for dungeon tanking which is what I mostly do. Admittedly a very, very unusual edge case which won't be relevant once I upgrade those "tanking dps" legs to a 2nd heroic version.

I mainly opened the ticket as I saw someone on discord confused about why their Item Equipped triggers weren't working, but I can see this being something not worth fixing due to how infrequent it is, especially when you can fix it by enabling Item Slot.

InfusOnWoW commented 2 weeks ago

It has come up often enough, that'll at least take a look at how complicated implementing it would be.