search

WealthBar / angular-d3

AngularJS directives for declaratively using D3
http://wealthbar.github.io/angular-d3/
MIT License
156 stars 39 forks source link

Bars can read from csv now. #6

Closed n00shie closed 11 years ago

n00shie commented 11 years ago

Had to manually copy your changes to main.html, since PR #5 is not merged yet. In retrospect, I was not sure whether I should have just committed my changes to bars.coffee. It makes sense if we assume your PR will be pulled first, in that case my PR is like a patch, or delta. However this prevents me from testing the code before pushing, so essentially, if we treat this PR in isolation, I would have been pushing a broken build.

Also I did not include data.csv, with the assumption that it will be included with PR #5

chrisnicola commented 11 years ago

Ah I just expected you to commit to that pull request. I'll cherry pick your commit over to it, it should work ok. You should have full read-write access to this repo.