search

WeaponMechanics / MechanicsMain

A New Age of Weapons in Minecraft.
https://www.spigotmc.org/resources/WeaponMechanics.99913/
MIT License
83 stars 27 forks source link

Command system compatibility for 1.12 and earlier #156

Open DeeCaaD opened 2 years ago

DeeCaaD commented 2 years ago

Link to code

https://github.com/WeaponMechanics/MechanicsMain/blob/master/CoreCompatibility/Core_1_19_R1/src/main/java/me/deecaad/core/compatibility/command/Command_1_19_R1.java#L77

Related Issues

No response

Improvements

Add really basic CommandCompatibility compatibility interface for 1.9 - 1.12. It doesn't have to be perfect with tab completions and targeters obviously, but this way we wont have to write commands code twice using deprecated command API in WM.

I'm not exactly sure how much work this is (since I didn't code that command system).

https://github.com/WeaponMechanics/MechanicsMain/tree/master/MechanicsCore/src/main/java/me/deecaad/core/commands

CJCrafter commented 2 years ago

should be able to write this to work with tabcompletions still, but I would need to code each argument type for older versions. There are a few 😟 image

DeeCaaD commented 2 years ago

Well... it will be worth it in the end :D

CJCrafter commented 2 years ago

I wonder if we can shade brigadier and somehow use that for perfect 1to1 command conversion?

DeeCaaD commented 2 years ago

I wonder if we can shade brigadier and somehow use that for perfect 1to1 command conversion?

I have no idea about whole command system, but that sounds good if it works