search

WearBlackAllDay / DimensionalThreading

An attempt to optimize the fabric server, by assigning each dimension their own thread.
MIT License
255 stars 22 forks source link

Crash on server startup #1

Closed Devon7925 closed 3 years ago

Devon7925 commented 3 years ago

See log attached crash-2020-09-25_18.21.28-server.txt

WearBlackAllDay commented 3 years ago

@Devon7925 I am sorry to only just see this, i did not expect to run into an issue report that quickly; however i am always happy to receive more data to improve the mod on. Concerning your crash, did you happen to use an outdated build?

Devon7925 commented 3 years ago

I don't think so. I used the 1.0 release. I tried both the dev and non dev version and neither seemed to work

Devon7925 commented 3 years ago

One thing that probably matters is that I was using a datapack with custom dimensions

Devon7925 commented 3 years ago

@WearBlackAllDay I think the problem is herehttps://github.com/WearBlackAllDay/DimensionalThreading/blob/03aec22a2c76f1147a16ce9417fad65251ce3ad4/src/main/java/dimthread/mixin/MinecraftServerMixin.java#L69. This fails if the dimension count is not 3. If you want I can send you a sample datapack that adds dimensions.

WearBlackAllDay commented 3 years ago

Yep, thats exactly it until there is a proper fix the solution for now would be manually adjusting the threadcount with an ingame command.

Devon7925 commented 3 years ago
  1. Increacing the threadcount doesn't fix this, that line needs to be changed
  2. An ingame command cant be run if you can't load the world
KaptainWutax commented 3 years ago

Kinda yoloed that since I was too lazy to write a datapack. It should do it hopefully. :p