search

WearBlackAllDay / DimensionalThreading

An attempt to optimize the fabric server, by assigning each dimension their own thread.
MIT License
256 stars 22 forks source link

Carpet /Tick Health Incorrect Values. #43

Closed NickVHoy11 closed 3 years ago

NickVHoy11 commented 3 years ago

When doing /tick health or any /tick command from carpet, the total tick time(is probably correct), and the "The rest, whatever that might be" is a negative number which does not make sense. This occurs when more than one dimension has a player. Tick When only one dimension is loaded the tick times are correct. Tick2 I assume this a caused by carpet summing the tick times from the breakdown, and then just throwing whatever the difference is from that sum and the actual total tick time it measured manually into "The rest, whatever that might be". Dimthreading's performance enhancement is causing the total summed tick time to be higher than the actual tick time returning the negative number. This might also be causing trouble for other tick related mods to help measure performance/lag. I am aware that this is more likely an error on Carpet's side, however the README says to post compatibility issues here for carpet/lithium feel free to mark as not fixing.

WearBlackAllDay commented 3 years ago

This has been known ever since the first release, but i always appreciate reasonable issues. Negative values in that context are not a bug, but expected behaviour in my book. Despite neither carpet nor dimthread being able to do anything about this, what number would you expect to show up instead? The negative number makes sense imo, obviosly needs to be interpreted correctly.