search

WearBlackAllDay / DimensionalThreading

An attempt to optimize the fabric server, by assigning each dimension their own thread.
MIT License
255 stars 22 forks source link

Bug of redstone dust signal #45

Open elder19260817 opened 2 years ago

elder19260817 commented 2 years ago

When this mod and /carpet fastRedstoneDust (fabric-carpet mod)are used at the same time, the signal of redstone powder will not be attenuated.And when /gamerule dimthread_active changed to false,the problem is still not solved.Only close fastredstonedust to solve the problem. 2021-11-02_20 53 15

xiaoyu2006 commented 2 years ago

@WearBlackAllDay I don't see why

{@code RedstoneWireBlock#wiresGivePower} is not thread-safe since it's a global flag. To ensure no interference between threads the field is replaced with this thread local one.


private boolean wiresGivePower = true;

RedstoneWireBlock#wiresGivePower is not a static field. Also deleting this Mixin seems to work fine. Can someone explains this to me? Thanks.