Undeclared dependency on Fabric API Gamerule

WearBlackAllDay / DimensionalThreading

An attempt to optimize the fabric server, by assigning each dimension their own thread.

MIT License

255 stars 22 forks source link

Undeclared dependency on Fabric API Gamerule #59

Open LoganDark opened 2 years ago

LoganDark commented 2 years ago

java.lang.ClassNotFoundException: net.fabricmc.fabric.api.gamerule.v1.GameRuleFactory

I can't use Fabric API on my server, so declaring this dependency would have allowed me to rule out DimensionalThreading from the start.

Perhaps you should disable the gamerules when Fabric API Gamerule is not installed.

xiaoyu2006 commented 2 years ago

I can't use Fabric API on my server

Why? I’m sure this issue won’t be supported.

LoganDark commented 2 years ago

I can't use Fabric API on my server

Why? I’m sure this issue won’t be supported.

Fabric API tends to have side effects such as automatically adding new S2C packets that I don't want on a vanilla server. I can get around this to some extent by extracting it and adding individual APIs but it's annoying to have to do that.