WearBlackAllDay / DimensionalThreading

An attempt to optimize the fabric server, by assigning each dimension their own thread.
MIT License
255 stars 22 forks source link

Incorrect dependency declaration #71

Open CaveNightingale opened 1 year ago

CaveNightingale commented 1 year ago

DimThread require fabric-game-rule-api-v1 for gamerule registering. However, it doesn't declare dependency on fabric-game-rule-api-v1 or fabric.

WearBlackAllDay commented 1 year ago

It declares a dep on the fabric api, of which the game rule api is a subset.

CaveNightingale commented 1 year ago

It declares a dep on the fabric api, of which the game rule api is a subset.

See your fabric.mod.json.

It declared deps on fabricloader and minecraft but not fabric (the modid of fabric-api).

Actually, dimthread throws a NoClassDefFoundError on my server when I try to reproduce the issue 72 with minimum mod set.