WearBlackAllDay / DimensionalThreading

An attempt to optimize the fabric server, by assigning each dimension their own thread.
MIT License
255 stars 22 forks source link

Fix various bad behaviors. #76

Open xiaoyu2006 opened 1 year ago

xiaoyu2006 commented 1 year ago

This couldn't be done without @CaveNightingale!

Boobies commented 1 year ago

I think this should be merged but, preferably, pulled from @CaveNightingale's branch, mainly because of a minor performance optimization.

xiaoyu2006 commented 1 year ago

I think this should be merged but, preferably, pulled from @CaveNightingale's branch, mainly because of a minor performance optimization.

@Boobies

They shouldn't be merged. Despite conflicts, @CaveNightingale's branch still have severe problems about entities going through the end portal.

CaveNightingale commented 1 year ago

I think this should be merged but, preferably, pulled from @CaveNightingale's branch, mainly because of a minor performance optimization.

@Boobies

They shouldn't be merged. Despite conflicts, @CaveNightingale's branch still have severe problems about entities going through the end portal.

Can you provide some details about the problem? I have installed my branch on my server. However, I receive no bug report about end portal/

xiaoyu2006 commented 1 year ago

I think this should be merged but, preferably, pulled from @CaveNightingale's branch, mainly because of a minor performance optimization.

@Boobies They shouldn't be merged. Despite conflicts, @CaveNightingale's branch still have severe problems about entities going through the end portal.

Can you provide some details about the problem? I have installed my branch on my server. However, I receive no bug report about end portal/

With your latest commit (6e35f6a), I started a server and created an end portal. However by throwing items quickly into the portal (holding the Q button) from the overworld the stuff may duplicate. Throwing from the end to overworld may cause item loss.

CaveNightingale commented 1 year ago

I think this should be merged but, preferably, pulled from @CaveNightingale's branch, mainly because of a minor performance optimization.

@Boobies They shouldn't be merged. Despite conflicts, @CaveNightingale's branch still have severe problems about entities going through the end portal.

Can you provide some details about the problem? I have installed my branch on my server. However, I receive no bug report about end portal/

With your latest commit (6e35f6a), I started a server and created an end portal. However by throwing items quickly into the portal (holding the Q button) from the overworld the stuff may duplicate. Throwing from the end to overworld may cause item loss.

Can reproduce. Thanks for your reporting.

CaveNightingale commented 1 year ago

I think this should be merged but, preferably, pulled from @CaveNightingale's branch, mainly because of a minor performance optimization.

@Boobies They shouldn't be merged. Despite conflicts, @CaveNightingale's branch still have severe problems about entities going through the end portal.

Can you provide some details about the problem? I have installed my branch on my server. However, I receive no bug report about end portal/

With your latest commit (6e35f6a), I started a server and created an end portal. However by throwing items quickly into the portal (holding the Q button) from the overworld the stuff may duplicate. Throwing from the end to overworld may cause item loss.

Fixed.

KLONOA9X6 commented 1 year ago

crash-2023-01-02_16.21.27-server.txt

CaveNightingale commented 1 year ago

crash-2023-01-02_16.21.27-server.txt

I have no idea why you post this crash report here. Describe your problem if the crash report is relevant to the discussion.

xiaofan7520 commented 1 year ago

crash-2023-01-02_16.21.27-server.txt

I have no idea why you post this crash report here. Describe your problem if the crash report is relevant to the discussion.

It's my server crash report. Mabe it's Issue #42

EGOIST1372 commented 1 year ago

so does this commit gonna merge or not? it seems fixes a lot of bugs

CaveNightingale commented 1 year ago

so does this commit gonna merge or not? it seems fixes a lot of bugs

Probably not. This repo is not supported anyway.