search

WeareJH / m2-module-import

Import module for Magento 2 - provides commands, utilities and abstractions for building imports for Magento 2 projects
MIT License
19 stars 8 forks source link

Fix PHP 8.1 error #49

Closed freezy-sk closed 1 year ago

freezy-sk commented 1 year ago

Magento running on PHP 8.1 raises fatal error:

During inheritance of Countable: Uncaught Exception: Deprecated Functionality: Return type of Jh\Import\Source\Db::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /app/vendor/wearejh/m2-module-import/src/Source/Db.php on line 57 in /app/vendor/magento/framework/App/ErrorHandler.php:61

Also allowed monolog ^2.1 for development, which allows install on PHP 8.1 and added php-parallel-lint for fast syntax checking on PHP 7.4 and 8.1

freezy-sk commented 1 year ago

@bartoszkubicki could you review it please?

bartoszkubicki commented 1 year ago

I am so sorry @freezy-sk that you've waited. It must have disappeared under other github notification. Actually I have just fixed main issue of that PR, but still other stuff is valuable input. Will issue new version today.

freezy-sk commented 1 year ago

@bartoszkubicki no problem ;) and thank you for merge and release