search

WeareJH / wf2

PHP environments for Magento 1, Magento 2 & Wordpress
6 stars 3 forks source link

feat: Added a check to see if wf2 is up to date when running up #95

Closed jflanaganuk closed 4 years ago

jflanaganuk commented 4 years ago

Added a check to the up command that will check if the version installed on the user's computer is the latest, if not it will prompt the user to update by running the existing self_update command.

shakyShane commented 4 years ago

I think in general we should discuss whether this is a valid feature.

since self-update is easy now, do we really need to bake-in an automatic check into this codebase?

Also what happens if you're offline? does it silently fail?

I think the check is valid, but I'm questioning whether it should be part of 'up' - if you are truly that bothered about being on the absolute latest version, you'd either check daily with self-update, or you'd compile it your self as I know some people do.

What I'm getting at here is that I don't think up (being the most used command) should be mixing in http requests to external services like github, when all you wanted to do was start some docker containers.

What about adding it to doctor instead?

What does everyone else think?

jflanaganuk commented 4 years ago

I think in general we should discuss whether this is a valid feature.

since self-update is easy now, do we really need to bake-in an automatic check into this codebase?

Also what happens if you're offline? does it silently fail?

I think the check is valid, but I'm questioning whether it should be part of 'up' - if you are truly that bothered about being on the absolute latest version, you'd either check daily with self-update, or you'd compile it your self as I know some people do.

What I'm getting at here is that I don't think up (being the most used command) should be mixing in http requests to external services like github, when all you wanted to do was start some docker containers.

What about adding it to doctor instead?

What does everyone else think?

If you would like, I could remove it from being called on "up" and we could just merge in the check_updates part? This way, it is ready for wherever we decide to put the check

I only put it on "up" because I swear during the dev meeting that we were coming up with this, someone said it would be a good place to check for updates?