Weasy666 / bevy_svg

A simple and incomplete SVG drawer for the Bevy engine.
Apache License 2.0
108 stars 26 forks source link

Samples fail if [3d] feature is not enabled #14

Closed targrub closed 1 year ago

targrub commented 2 years ago

Modifying the [features] block of Cargo.toml to

[features]
default = ["2d"]
2d = ["bevy/bevy_sprite"]

yielded me the following warnings

2022-09-13T21:47:08.231401Z  WARN bevy_ecs::schedule::graph_utils: bevy_window::system::exit_on_all_closed wants to be after unknown label: ModifiesWindows
2022-09-13T21:47:08.231600Z  WARN bevy_ecs::schedule::graph_utils: bevy_render::camera::camera::camera_system<bevy_render::camera::projection::Projection> wants to be after unknown label: ModifiesWindows
2022-09-13T21:47:08.231817Z  WARN bevy_ecs::schedule::graph_utils: bevy_render::camera::camera::camera_system<bevy_render::camera::projection::OrthographicProjection> wants to be after unknown label: ModifiesWindows  
2022-09-13T21:47:08.231954Z  WARN bevy_ecs::schedule::graph_utils: bevy_render::camera::camera::camera_system<bevy_render::camera::projection::PerspectiveProjection> wants to be after unknown label: ModifiesWindows

no window, and the end of execution for any of the 2d example programs. This is with the latest code in main.

Weasy666 commented 2 years ago

Hm...i am not able to reproduce this error, but you shouldn't just remove a feature from Cargo.toml which is used to include/remove parts of the code.

Can you try cargo run --example 2d_two_colors --no-default-features --features 2d instead of removing something from Cargo.toml? Do you then still get the error?

targrub commented 2 years ago

You're right; reverting my changes to bevy_svg's Cargo.toml and running it as you suggest got the example working again.

However, if I do this:

[dev-dependencies]
bevy = { version = "0.8", default-features = false, features = ["bevy_asset", "bevy_core_pipeline", "bevy_render"] }
#bevy = { version = "0.8", default-features = true }

I get the error.

Weasy666 commented 1 year ago

Sorry for the late reply. If you haven't already solved it, adding the "bevy_winit" feature solves your problem. Without a window from the OS, Bevy can't draw the pipeline result anywhere.

If you have any questions left, feel free to ask, i'll try to answer as fast as i can.