search

Weasyl / weasyl

The website.
https://www.weasyl.com
Apache License 2.0
115 stars 30 forks source link

Improve tag suggestions #1372

Closed charmander closed 1 year ago

charmander commented 1 year ago

Undo tokens might be a temporary measure while all content types gain history tables, or they might become permanent, in which case improved secret management (separate storage, key rotation with MultiFernet) can be implemented later.

A list of tags that have been rejected for being abusive isn’t exposed anywhere yet, but I’ll check for them manually while the project to redo the entire mod UI is in progress.

Migration should run before web servers are switched over.

codecov[bot] commented 1 year ago

Codecov Report

Merging #1372 (a97d9e1) into main (360fa0a) will decrease coverage by 0.45%. The diff coverage is 53.15%.

@@            Coverage Diff             @@
##             main    #1372      +/-   ##
==========================================
- Coverage   60.08%   59.63%   -0.45%     
==========================================
  Files          93       94       +1     
  Lines        8871     9067     +196     
  Branches     1622     1635      +13     
==========================================
+ Hits         5330     5407      +77     
- Misses       3107     3226     +119     
  Partials      434      434
Impacted Files Coverage Δ
weasyl/controllers/routes.py 100.00% <ø> (ø)
weasyl/controllers/settings.py 41.08% <0.00%> (-0.46%) :arrow_down:
weasyl/welcome.py 73.13% <ø> (-1.52%) :arrow_down:
weasyl/controllers/content.py 44.34% <17.10%> (-1.72%) :arrow_down:
weasyl/forms.py 29.41% <29.41%> (ø)
weasyl/searchtag.py 75.15% <66.05%> (-19.18%) :arrow_down:
weasyl/submission.py 55.62% <75.00%> (ø)
weasyl/controllers/detail.py 53.46% <83.33%> (+1.91%) :arrow_up:
libweasyl/models/tables.py 100.00% <100.00%> (ø)
weasyl/character.py 57.69% <100.00%> (ø)
... and 1 more

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

charmander commented 1 year ago

Thanks for checking it out, @kfkitsune! Both behaviors are intended. I thought it would strike a good usefulness balance and encourage people to suggest as many tags as they want without worrying about sending annoying notifications. The differences between approved and suggested tags are that the latter show up at the end, in a different style, and not to guests. (The reason welcome type 3140 is still handled in the notification list is because this doesn’t delete existing notifications.)

kfkitsune commented 1 year ago

Might be worth a distinct issue/PR to address, but I had to also edit ./wzl to replace all instances of docker-compose with docker compose (dropping the hyphen); following the official Docker installation instructions for a fresh Debian 12 install does not provide the docker-compose command:

kyra@kitty:~/git/weasyl$ ./wzl configure
+ docker-compose run --rm -T configure alembic.ini
./wzl: 40: docker-compose: not found
kyra@kitty:~/git/weasyl$ sudo apt-get install docker-compose-plugin
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
docker-compose-plugin is already the newest version (2.19.1-1~debian.12~bookworm).
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
kyra@kitty:~/git/weasyl$ docker compose version
Docker Compose version v2.19.1
charmander commented 1 year ago

I’ve had to do that locally too for a while but didn’t commit it because of Debian backwards-compatibility! :D Okay, will commit a version that checks whether docker-compose exists.