codecov[bot]
commented
6 months ago Codecov Report
Attention: 18 lines in your changes are missing coverage. Please review.
Comparison is base (
0fa4c53) 59.75% compared to head (a652965) 59.84%.
| Files | Patch % | Lines |
|---|---|---|
| weasyl/controllers/profile.py | 45.45% | 12 Missing :warning: |
| weasyl/moderation.py | 0.00% | 4 Missing :warning: |
| weasyl/character.py | 66.66% | 1 Missing :warning: |
| weasyl/journal.py | 66.66% | 1 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #1390 +/- ## ========================================== + Coverage 59.75% 59.84% +0.09% ========================================== Files 94 94 Lines 9054 9120 +66 Branches 1635 1642 +7 ========================================== + Hits 5410 5458 +48 - Misses 3210 3228 +18 Partials 434 434 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
charmander
The counts respect the viewer’s rating preference. Sets up for some future changes:
determining whether SFW mode has an effect when the configured rating preference is the same between SFW mode and non, so we can avoid confusingly showing a toggle that does nothing
making blocked tag filtering a visible operation on pages of results (which itself sets up for better pagination and performance improvements through caching and lightened database load)
I’d like to provide counts for favorites and individual folders too, but they’re more involved. Ideally, counts would be stored in the database and updated eagerly; PostgreSQL makes it hard.