Weather-Station-Software / live-weather-station

Display on your WordPress site, in many elegant ways, the meteorological data collected by public or personal weather stations.
https://weather.station.software/
GNU General Public License v2.0
7 stars 2 forks source link

Fix typos #27

Closed szepeviktor closed 1 year ago

szepeviktor commented 1 year ago

Fix half the misspellings with typos.

I took the liberty to rename $unit_espace = ' '; to $unit_nbspace leaving espace to Renault :)

.typos.toml

[files]
extend-exclude = [
    "public/css/",
    "public/font/",
    "public/js/"
]
[default.extend-identifiers]
"ND" = "ND"
"WeeWX" = "WeeWX"
"Wordpress" = "WordPress"
[default.extend-words]
# The other half to fix
"datas" = "datas"
"informations" = "informations"
"serie" = "serie"

Please consider renaming: datas, informations, serie - these are not in English. You may also like https://github.com/szepeviktor/uninformative-words

jaz-on commented 1 year ago

Thanks @szepeviktor for the PR. I didn't know about crate-ci/typos and your little repo, II appreciate it.

I'll dig into it and learn how to apply it to this project, it's going to be very useful when it comes to checking simple mistakes.

May I ask you how you ended up reviewing the Weather Station plugin repo? :)

szepeviktor commented 1 year ago

how you ended up reviewing the Weather Station plugin repo? :)

This way

image

szepeviktor commented 1 year ago

Please consider renaming: datas, informations, serie - these are not in English.

The next step could be.

https://github.com/search?q=repo%3AWeather-Station-Software%2Flive-weather-station%20%22informations%22&type=code

In English, "information" is an uncountable mass noun.

jaz-on commented 1 year ago

Pierre, the original developer, and I are French.

As these words are also used in French (and countable in our mother language), we made mistakes when naming parts of the codebase...

I'll work on it and be way more strict on the naming convention in the future thanks for the heads-up!😉

szepeviktor commented 1 year ago

ChatGPT agrees!

image