search

WeatherElectric / Lacrimosum

Risk Of Rain 2-based items for Lethal Company
0 stars 0 forks source link

[BUG] Ukelele breaks after hitting an enemy with it #5

Open Lunxara opened 2 weeks ago

Lunxara commented 2 weeks ago

I whacked an enemy with the Ukelele and then it broke and became completely unusable :(

[10:46:37.7304942] [Error : Unity Log] IndexOutOfRangeException: Index was outside the bounds of the array. Stack trace: RoundManager.PlayRandomClip (UnityEngine.AudioSource audioSource, UnityEngine.AudioClip[] clipsArray, System.Boolean randomize, System.Single oneShotVolume, System.Int32 audibleNoiseID, System.Int32 maxIndex) (at <066a7b7eb8c24d4facd1e255e669803f>:IL_0029) Lacrimosum.ItemScripts.Ukulele.HitShovel (System.Boolean cancel) (at <4f6e24dc6b1e49718ecbd5074ab31fa1>:IL_0334) Lacrimosum.ItemScripts.Ukulele+d__15.MoveNext () (at <4f6e24dc6b1e49718ecbd5074ab31fa1>:IL_0196) UnityEngine.SetupCoroutine.InvokeMoveNext (System.Collections.IEnumerator enumerator, System.IntPtr returnValueAddress) (at :IL_0026)

[10:46:37.7324959] [Error :UnityDebuggerAssistant]

--- Exception Handler ---

Exception Caught: System.IndexOutOfRangeException Assembly: Assembly-CSharp Message: Index was outside the bounds of the array. Source: Assembly-CSharp

--- Begin Frames ---

--FRAME 1: In Assembly: Assembly-CSharp Target Method: RoundManager.PlayRandomClip

--FRAME 2: In Assembly: Lacrimosum Target Method: Ukulele.HitShovel

--FRAME 3: In Assembly: Lacrimosum Target Method: d__15.MoveNext

--FRAME 4: In Assembly: UnityEngine.CoreModule Target Method: SetupCoroutine.InvokeMoveNext

--- End Frames ---

--- End Exception Handler ---

FragileDeviations commented 2 weeks ago

This seems to be basegame? Fault lies in RoundManagar.PlayRandomClip

Lunxara commented 2 weeks ago

This seems to be basegame? Fault lies in RoundManagar.PlayRandomClip

I don't believe so, as I've not had this issue with vanilla shovels or custom shovels from mods like VoidLeak, ImmersiveScrap, and CodeRebirth. I just imagine something is setup improperly. I think Xu said they're gonna see why it's happening and help you out ^^

FragileDeviations commented 2 weeks ago

This seems to be basegame? Fault lies in RoundManagar.PlayRandomClip

I don't believe so, as I've not had this issue with vanilla shovels or custom shovels from mods like VoidLeak, ImmersiveScrap, and CodeRebirth. I just imagine something is setup improperly. I think Xu said they're gonna see why it's happening and help you out ^^

VoidLeak uses the original unmodified shovel script, and I know since that's also my mod lol But yea that'd be appreciated if they're gonna see why, I have no idea where to start on fixing it because I'm just using the vanilla shovel's code with an extra method call slapped in

Lunxara commented 2 weeks ago

This seems to be basegame? Fault lies in RoundManagar.PlayRandomClip

I don't believe so, as I've not had this issue with vanilla shovels or custom shovels from mods like VoidLeak, ImmersiveScrap, and CodeRebirth. I just imagine something is setup improperly. I think Xu said they're gonna see why it's happening and help you out ^^

VoidLeak uses the original unmodified shovel script, and I know since that's also my mod lol But yea that'd be appreciated if they're gonna see why, I have no idea where to start on fixing it because I'm just using the vanilla shovel's code with an extra method call slapped in

Yeahh I just wonder why the additional method call is causing issues, maybe for now you could just try using the unmodified vanilla shovel code until Xu can help you look into it. Also I would recommend adding an option to not replace the menu music with ROR2's theme at all since I noticed that's rng, just to avoid potential DMCA issues for streams

FragileDeviations commented 2 weeks ago

This seems to be basegame? Fault lies in RoundManagar.PlayRandomClip

I don't believe so, as I've not had this issue with vanilla shovels or custom shovels from mods like VoidLeak, ImmersiveScrap, and CodeRebirth. I just imagine something is setup improperly. I think Xu said they're gonna see why it's happening and help you out ^^

VoidLeak uses the original unmodified shovel script, and I know since that's also my mod lol But yea that'd be appreciated if they're gonna see why, I have no idea where to start on fixing it because I'm just using the vanilla shovel's code with an extra method call slapped in

Yeahh I just wonder why the additional method call is causing issues, maybe for now you could just try using the unmodified vanilla shovel code until Xu can help you look into it. Also I would recommend adding an option to not replace the menu music with ROR2's theme at all since I noticed that's rng, just to avoid potential DMCA issues for streams

Luckily, RoR2 music doesn't get copystriked at all. Chris is cool with licensing. If it was a problem, every ror2 stream ever would no longer exist.

Lunxara commented 2 weeks ago

This seems to be basegame? Fault lies in RoundManagar.PlayRandomClip

I don't believe so, as I've not had this issue with vanilla shovels or custom shovels from mods like VoidLeak, ImmersiveScrap, and CodeRebirth. I just imagine something is setup improperly. I think Xu said they're gonna see why it's happening and help you out ^^

VoidLeak uses the original unmodified shovel script, and I know since that's also my mod lol But yea that'd be appreciated if they're gonna see why, I have no idea where to start on fixing it because I'm just using the vanilla shovel's code with an extra method call slapped in

Yeahh I just wonder why the additional method call is causing issues, maybe for now you could just try using the unmodified vanilla shovel code until Xu can help you look into it. Also I would recommend adding an option to not replace the menu music with ROR2's theme at all since I noticed that's rng, just to avoid potential DMCA issues for streams

Luckily, RoR2 music doesn't get copystriked at all. Chris is cool with licensing. If it was a problem, every ror2 stream ever would no longer exist.

Hooray, my main concern though was that I figured he might not like his music used in other games but if he's chill with it then good

FragileDeviations commented 2 weeks ago

he's never taken down things that use his ror songs that arent getting any money made off of them and are directly ror2 based, the mod's ror2 based and i dont make money off it

Lunxara commented 2 weeks ago

he's never taken down things that use his ror songs that arent getting any money made off of them and are directly ror2 based, the mod's ror2 based and i dont make money off it

Yay :D