Closed roblabs closed 2 years ago
Looks like the tests are failing due to an environment variable.
I understand how its set in my local build, but how is it managed for the CI builds?
Looks like the tests are failing due to an environment variable.
I understand how its set in my local build, but how is it managed for the CI builds?
@roblabs AFAIK PRs don't seem to get access to a repo's secrets, even after my approval to run. Ill test this on my machine soon and manually approve and merge. thanks for your PR in advance :)
Great, @ualch9. I added two tests for the Bellevue, WA area: one with a request for °C and one with a request for °F. I can't recall if GitHub actions return the .xctestResult
Testing bundle, but your local tests should show those results.
Great repo!
Allow API customers to set the Swift Foundation
UnitTemperature
to get either US or SI (metric) results from the APIpre-release
usage - https://github.com/roblabs/NationalWeatherService-Swift/releases/tag/0.4.2-betaExample usage with this change:
SI (metric) units
US customary