WeatherXM / -DEPRECATED-issue-tracker

[DEPRECATED] The old Issue Tracker for WeatherXM beta testers.
16 stars 1 forks source link

Selecting a point in the historical UV Index chart does not show the lines for X-value and Y-value #154

Closed Greg15 closed 1 year ago

Greg15 commented 1 year ago

WeatherXM Related Element

Please pick one of the following WeatherXM elements that are applicable for this bug:

Describe the bug

When clicking on a data point in the UV Index historical chart, the corresponding vertical and horizontal data point lines aren't drawn that are shown in all other historical data charts. This causes a little bit more looking to confirm if the displayed pop-up is for the data point the user intended to click on with their finger.

How To Reproduce

Steps to reproduce the behavior:

  1. Go to historical weather data charts
  2. Click on a data point in any chart except UV INDEX, for example, the Pressure Chart
  3. Notice that the graph displays a vertical line for the time of the selected data point,and notice the graph shows a horizontal line for the weather data value of the selected data point
  4. Now click on a data point in the UV INDEX. Notice that similar lines are not drawn.

Expected behavior

The data point lines would display, just like is done in all other historical data charts

Screenshots

Screenshot_20221111-130742.png

If Applicable: Smartphone (please complete the following information that are needed for this bug):

Additional context

I recognize that the UV Index chart is a bar chart, and all the other charts are line charts, so I recognize that they underlying chart features might not be the same. But when clicking on a data point in the UV Index historical chart, it always takes me a bit longer to confirm if the displayed pop-up is for the data point I intended to click on with my finger. It's a little disorienting, and is a bit more frustrating than need be when trying to click on a particular data point and fat-fingering the wrong data point.

RevNotDev commented 1 year ago

Using Bluestacks I get the same happening as Greg.

PavlosTze commented 1 year ago

Thanks for that @Greg15 and @RevNotDev . Actually this is a different bug, the bars should get a different color when selected, whereas they didn't. I have implemented a fix that will be out in the next release, where the bar selected will get painted in a different color.

Greg15 commented 1 year ago

I assume that the bar color change won't indicate which data point is selected if selection is a UV INDEX of zero, since no bar?

My guess is that it's the best option available, but still not as complete as the data point selection feedback in line charts

PavlosTze commented 1 year ago

I assume that the bar color change won't indicate which data point is selected if selection is a UV INDEX of zero, since no bar?

My guess is that it's the best option available, but still not as complete as the data point selection feedback in line charts

Unfortunately this functionality isn't available in the charts' library, but even if it was I am not sure that would be a correct one as a bar isn't an actual data point like a line consists of many data points.

But in any case, we will think if there is another way to show it in a redesign we are doing regarding the historical charts and especially the popup/highlighting of values.

PavlosTze commented 1 year ago

Fixed on the latest beta version. Thank you!