search

Weatherlights / Winget-AutoUpdate-Intune

WAUaaS daily updates apps as system and notify users. WAUaaS brings you WAU in a service like pattern that can be deployed and configured by Microsoft Intune (or other MDM solutions).
MIT License
116 stars 6 forks source link

[Bug]: Notification says "update failed" but it worked and log says "Erfolgreich installiert" #19

Closed flotpg closed 5 months ago

flotpg commented 9 months ago

The problem

Hi Hauke,

I noticed this issue on the machines I'm testing this nice solution.

I get the notification that the update has failed but in reality it worked. The updates.log says "erfolgreich installiert" and then claims the update failed. Is this due some regional settings / issues?

This is just an example and it looks to me, that it always says "... update failed" when the previous message was similar to "Die Installation war erfolgreich" or in german.

What version of WAU has the issue?

1.17.6-2

What version of Windows are you using (ex. Windows 11 22H2)?

Windows 11 22H2

What version of winget are you using?

v1.6.2771

Log information

##################################################
#     CHECK FOR APP UPDATES - 09.10.2023
##################################################
11:50:05 - Running in User context
11:50:05 - Notification Level: Full. Notification Language: English
11:50:05 - Checking internet connection...
11:50:05 - Connected !
11:50:10 - Winget Version: v1.6.2771
11:50:10 - WAU current version: 1.17.6-2
11:50:10 - WAU uses Black List config
11:50:10 - Checking application updates on Winget Repository...
-> Available update : Microsoft Teams. Current version : 1.5.00.30767. Available version : 1.6.00.26474.
11:50:13 - Updating Microsoft Teams from 1.5.00.30767 to 1.6.00.26474...
11:50:16 - ##########   WINGET UPGRADE PROCESS STARTS FOR APPLICATION ID 'Microsoft.Teams'   ##########
11:50:16 - -> Running: Winget upgrade --id Microsoft.Teams --accept-package-agreements --accept-source-agreements -h
   -                                                                                                                     
   - 
   \ 

Es wurde kein installiertes Paket gefunden, das den Eingabekriterien entspricht.
11:50:22 - -> An upgrade for Microsoft Teams failed, now trying an install instead...
11:50:22 - -> Running: Winget install --id Microsoft.Teams --accept-package-agreements --accept-source-agreements --force -h
   - 

Gefunden Microsoft Teams [Microsoft.Teams] Version 1.6.00.26474
Diese Anwendung wird von ihrem Besitzer an Sie lizenziert.
Microsoft ist nicht verantwortlich und erteilt keine Lizenzen für Pakete von Drittanbietern.
Download läuft https://statics.teams.cdn.office.net/production-windows-x64/1.6.00.26474/Teams_windows_x64.exe

   - 
   \ 
   | 
   / 
   - 
   \ 
   | 
   / 
   - 
    ███████████████▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒  71.0 MB /  136 MB
  ██████████████████████████████   136 MB /  136 MB
Der Installer-Hash wurde erfolgreich überprüft
Paketinstallation wird gestartet...
   - 
   \ 
   | 
   /                                                                                                       
Erfolgreich installiert
11:51:37 - ##########   WINGET UPGRADE PROCESS FINISHED FOR APPLICATION ID 'Microsoft.Teams'   ##########
11:51:37 - Microsoft Teams update failed.
11:51:40 - No new update.
11:51:40 - End of process!


### Additional information

_No response_
nameproof commented 8 months ago

Having the same issue on v. 1.17.8. Win 11 22H2. Winget v1.6.2771 After the log I can verify that OhMyPosh was updated. No OnSuccess notification gets triggered since it seems to think it failed.

##################################################
#     CHECK FOR APP UPDATES - 2023-10-30
##################################################
07:01:22 - Running in System context
07:01:22 - Notification Level: SuccessOnly. Notification Language: Svenska
07:01:22 - Checking internet connection...
07:01:23 - Connected !
07:01:31 - Winget Version: v1.6.2771
07:01:31 - WAU current version: 1.17.8
07:01:31 - WAU AutoUpdate is Disabled.
07:01:31 - WAU uses External Lists from: C:\ProgramData\Winget-AutoUpdate-Configurator
07:01:31 - Newer List downloaded/copied to local path: C:\ProgramData\Winget-AutoUpdate
07:01:31 - WAU uses External Mods from: C:\ProgramData\Winget-AutoUpdate-Configurator\mods
07:01:31 - Mods are up to date.
07:01:31 - WAU uses Black List config
07:01:32 - Checking application updates on Winget Repository...
07:01:34 - An unusual thing happened (maybe all apps are upgraded):

   - 
   \ 

  ███▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒  1024 KB / 8.25 MB
  ███████▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒  2.00 MB / 8.25 MB
  ██████████▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒  3.00 MB / 8.25 MB
  ██████████████▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒  4.00 MB / 8.25 MB
  ██████████████████▒▒▒▒▒▒▒▒▒▒▒▒  5.00 MB / 8.25 MB
  █████████████████████▒▒▒▒▒▒▒▒▒  6.00 MB / 8.25 MB
  █████████████████████████▒▒▒▒▒  7.00 MB / 8.25 MB
  █████████████████████████████▒  8.00 MB / 8.25 MB
  ██████████████████████████████  8.25 MB / 8.25 MB

   - 

No installed package found matching input criteria.

07:01:34 - No new update.
07:01:37 - User logged on, get a list of installed Winget apps in System context...
07:01:43 - Starting WAU in User context

##################################################
#     CHECK FOR APP UPDATES - 2023-10-30
##################################################
07:01:52 - Running in User context
07:01:53 - Notification Level: SuccessOnly. Notification Language: Svenska
07:01:53 - Checking internet connection...
07:01:53 - Connected !
07:02:00 - Winget Version: v1.6.2771
07:02:00 - WAU current version: 1.17.8
07:02:00 - WAU uses Black List config
07:02:00 - Checking application updates on Winget Repository...
-> Available update : Microsoft Teams. Current version : 1.6.00.22378. Available version : 23257.2618.2432.4374.
-> Available update : Oh My Posh version 18.15.0. Current version : 18.15.0. Available version : 18.17.0.
-> Available update : Teams Machine-Wide Installer. Current version : 1.5.0.30767. Available version : 23257.2618.2432.4374.
07:02:05 - Microsoft Teams : Skipped upgrade because it is in the excluded app list
07:02:06 - Updating Oh My Posh version 18.15.0 from 18.15.0 to 18.17.0...
07:02:06 - ##########   WINGET UPGRADE PROCESS STARTS FOR APPLICATION ID 'JanDeDobbeleer.OhMyPosh'   ##########
07:02:06 - -> Running: Winget upgrade --id JanDeDobbeleer.OhMyPosh --accept-package-agreements --accept-source-agreements -h

   - 
   \ 
   | 
   / 
   - 
   \ 

   - 
   \ 
   | 
   / 

Found Oh My Posh [JanDeDobbeleer.OhMyPosh] Version 18.17.0
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://github.com/JanDeDobbeleer/oh-my-posh/releases/download/v18.17.0/install-amd64.exe

   - 
   \ 
   | 
   / 
   - 
   \ 
   | 
   / 

  ████▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒  1024 KB / 6.22 MB
  ██████████████████████████████  6.22 MB / 6.22 MB
Successfully verified installer hash
Starting package install...

   - 
   \ 
   | 
   / 
   - 
   \ 
   | 
   / 
   - 
   \ 
   | 
   / 
   - 
   \ 
   | 
   / 
   - 
   \ 
   | 
   / 
   - 
   \ 
   | 
   / 
   - 
   \ 
   | 
   / 
   - 
   \ 
   | 
   / 
   - 
   \ 
   | 
   / 
   - 
   \ 
   | 
   / 
   - 
   \ 
   | 
   / 
   - 
   \ 
   | 
   / 
   - 
   \ 
   | 
   / 
   - 
   \ 
   | 
   / 
   - 
   \ 
   | 
   / 
   - 
   \ 
   | 
   / 
   - 
   \ 
   | 
   / 
   - 
   \ 
   | 
   / 
   - 
   \ 
   | 
   / 
   - 
   \ 
   | 
   / 
   - 
   \ 
   | 
   / 
   - 
   \ 
   | 
   / 
   - 

Successfully installed
07:02:47 - -> An upgrade for Oh My Posh version 18.15.0 failed, now trying an install instead...
07:02:47 - -> Running: Winget install --id JanDeDobbeleer.OhMyPosh --accept-package-agreements --accept-source-agreements --force -h

   - 

Found Oh My Posh [JanDeDobbeleer.OhMyPosh] Version 18.17.0
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://github.com/JanDeDobbeleer/oh-my-posh/releases/download/v18.17.0/install-amd64.exe

   - 
   \ 
   | 
   / 
   - 
   \ 

  ████▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒  1024 KB / 6.22 MB
  ██████████████████████████████  6.22 MB / 6.22 MB
Successfully verified installer hash
Starting package install...

   - 
   \ 
   | 

Successfully installed
07:02:54 - ##########   WINGET UPGRADE PROCESS FINISHED FOR APPLICATION ID 'JanDeDobbeleer.OhMyPosh'   ##########
07:02:54 - Oh My Posh version 18.15.0 update failed.
07:02:54 - Teams Machine-Wide Installer : Skipped upgrade because it is in the excluded app list
07:02:54 - No new update.
07:02:54 - End of process!
flotpg commented 8 months ago

I also saw some strange behaviour with TeamViewer Host updates. It first tries to update the currently install MSI but fails and then installs via the setup.exe over the current install which results in:

  1. loss of already configured settings
  2. two installation entries in appwiz.cpl

Can I prevent the install retry via different setup?

github-actions[bot] commented 7 months ago

This issue is stale because it has been open for 30 days with no activity.

flotpg commented 7 months ago

Can we provide anything else to help fixing this?

Weatherlights commented 6 months ago

Hey. Not all apps can be updated with Winget yet. Sadly this issue is with winget and how Teamviewer packages their applications. You should avoid the app using the white-/blacklist.

Same goes for Teams: Use the Teams updater or switch to the new Teams App.

regarding ohmyposh this seems strange. I use it aswell but updating works without any issues. But I will check on the upstream project so see if an update might help out here.

flotpg commented 6 months ago

thanks a lot. Can I prevent the install retry via different installer?

github-actions[bot] commented 5 months ago

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] commented 5 months ago

This issue was closed because it has been inactive for 14 days since being marked as stale.