Weatherlights / Winget-AutoUpdate-Intune

WAUaaS daily updates apps as system and notify users. WAUaaS brings you WAU in a service like pattern that can be deployed and configured by Microsoft Intune (or other MDM solutions).
MIT License
140 stars 6 forks source link

[Feature Request]: Consider log location #40

Closed MarcoBuess closed 1 week ago

MarcoBuess commented 1 month ago

The request

It would be nice if you'd consider putting the log files to the IMEs (Intune Management Extension) log location if applicable (like Romanitho suggests). Problem is, that C:\Windows\Temp can not be accessed easily remotely on Entra joined devices. Therefore if a user doesn't have local admin permission (which most shouldn't) there is no way you can get access to the logs. You can collect them remotely through Intune, which will collect everything under C:\ProgramData\Microsoft\IntuneManagementExtension\Logs.

Is your feature request related to a problem?

No response

Additional information

No response

Weatherlights commented 1 month ago

Thank you for the comment :). I will reconsider it... My design decision was not to tamper in folders that do not belong to other applications (In my opinion this is bad style since you create dependencies that can lead to issues out of my control). The Logfiles under c:\Windows\temp can also be collected through the Collect Logs feature (I made sure to select a folder and naming pattern that is on the list of folders that is supported for collection of logs). But I can fully understand and will rethink it since most other applications also decided to use the IME folder aswell and it is far easier to access on the local machine.

MarcoBuess commented 1 month ago

Thanks for the quick response. I do understand what you mean and I think you can now specify which folder you want to collect from within intune. Using the IME is kinda common practice though and you could always fall back to %windir%\temp if the directory doesn't exist. If you need me to file a PR for that I'll gladly look at the code.

Weatherlights commented 1 month ago

Give me a moment :)... I just want to rethink this in all directions... maybe adding an additional log location as a parameter to the ADMX/ADML.

MarcoBuess commented 1 month ago

Would make sense. Also log location seems to be kinda hard coded in these locations:

  1. https://github.com/Weatherlights/Winget-AutoUpdate-Intune/blob/117479f7a6e7078b1d4a5b1e67a4a7090ef4447a/Refresh-WingetConfiguration.ps1#L320
  2. https://github.com/Weatherlights/Winget-AutoUpdate-Intune/blob/ed0fcd136b271f190b4f5a2fe6a7c5bf621e77ed/WinGet-AutoUpdate-Configurator/Generic.psm1#L28
github-actions[bot] commented 3 weeks ago

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] commented 1 week ago

This issue was closed because it has been inactive for 14 days since being marked as stale.