search

Web-Dev-Path / web-dev-path

The Web Dev Path platform. Progressive Web App (PWA). Next.js rules!
https://webdevpath.co
GNU General Public License v3.0
33 stars 11 forks source link

Adding "Wanna learn more?" and "How to get started?" sections to the About Us page #130

Closed cherylli closed 2 years ago

cherylli commented 2 years ago
Web Dev Path
125

Have you updated the CHANGELOG.md file? If not, please do it.

yes

What is this change?

  1. Add wanna learn more part in about page
  2. modify TwoColumn to accept a second column of text (or other components) instead of an image

Were there any complications while making this change?

no

How did you verify this change?

run locally in desktop and mobile view

When should this be merged?

after review

netlify[bot] commented 2 years ago

Deploy Preview for priceless-booth-2dfcaf ready!

Name Link
Latest commit 4efd01027a02933fd952378a369ffe1908ac61c6
Latest deploy log https://app.netlify.com/sites/priceless-booth-2dfcaf/deploys/631f27b853ad9e00095cf631
Deploy Preview https://deploy-preview-130--priceless-booth-2dfcaf.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

cherylli commented 2 years ago

Do we need to change the text and link for "How to get started?" since we changed it so they are not sent to slack first?

mariana-caldas commented 2 years ago

Do we need to change the text and link for "How to get started?" since we changed it so they are not sent to slack first?

Great catch, @cherylli ! 🥇 I've updated the content in the mockup to:

"After taking a look at our project README and wiki, just send us an email sharing with us about your journey in tech and why you’re interested in joining us. We've got you!"

I've added the links there to the README and wiki as well. The "Ping Us" link should take the users to the project email, as we see on the "Join us" navigation link. Please let me know if that makes sense, Cheryl! 🚀

cherylli commented 2 years ago

updated. should be good to go

klezi10 commented 2 years ago

Just noticed that the "contact us" button under "experienced developers" looks different in the design https://www.figma.com/file/Fp0lLB5OWZLJseTs2svGbg/Web-Dev-Path_design?node-id=414%3A936

Not sure if it was discussed elsewhere but thought I'd bring it up just in case.

cherylli commented 2 years ago

Just noticed that the "contact us" button under "experienced developers" looks different in the design https://www.figma.com/file/Fp0lLB5OWZLJseTs2svGbg/Web-Dev-Path_design?node-id=414%3A936

Not sure if it was discussed elsewhere but thought I'd bring it up just in case.

I just assume it's to show the hover style 🤔. Might need a confirmation from the @Web-Dev-Path/designers