Web-Dev-Path / web-dev-path

The Web Dev Path platform. Progressive Web App (PWA). Next.js rules!
https://webdevpath.co
GNU General Public License v3.0
33 stars 11 forks source link

Fix invalid next.config.js due to changes in newer next.js version #170

Closed cherylli closed 1 year ago

cherylli commented 1 year ago
Web Dev Path
169

Have you updated the CHANGELOG.md file? If not, please do it.

yes

What is this change?

fix invalid next.config.js warnings due to changes in a newer next.js version

Were there any complications while making this change?

no

How did you verify this change?

run locally

When should this be merged?

after review

netlify[bot] commented 1 year ago

Deploy Preview for priceless-booth-2dfcaf ready!

Name Link
Latest commit 5e649fcb8ff463387e03706e1ac060a4756eb433
Latest deploy log https://app.netlify.com/sites/priceless-booth-2dfcaf/deploys/646edf0ee7ad370008214a78
Deploy Preview https://deploy-preview-170--priceless-booth-2dfcaf.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

mariana-caldas commented 1 year ago

Great job, @cherylli ! The warning is gone on my end! 🎉

When you go to the blog page, do you also see this error related to the Tag styling? I wonder if it's caused by the missing styled-components options we're removing.

image

cherylli commented 1 year ago

Now I remember why we need the styled-components in the config, it's needed for SSR mostly which we use in the blog page. I might try to use another way so we don't see the warning

cherylli commented 1 year ago

it should run without error now but when/if we ever going to migrate to the new next.js app structure, we might have to redo this again, as they have another method in the beta docs

cherylli commented 1 year ago

image