Web-Dev-Path / web-dev-path

The Web Dev Path platform. Progressive Web App (PWA). Next.js rules!
https://webdevpath.co
GNU General Public License v3.0
33 stars 11 forks source link

Add Embedding youtube videos #183

Closed LuSilvaDeveloper closed 1 year ago

LuSilvaDeveloper commented 1 year ago
Web Dev Path
179

Have you updated the CHANGELOG.md file? If not, please do it.

Yes.

What is this change?

Added Embedding youtube videos.

Were there any complications while making this change?

Yes, First I tried to use JSX and styled-components, but after some research, I found that I couldn't use them, so I changed to HTML and CSS files. After that, I found that I couldn't use an external CSS for that purpose, so I had to just put everything inside the HTML file.

How did you verify this change?

The changes will be verified after the merge.

When should this be merged?

After review

netlify[bot] commented 1 year ago

Deploy Preview for priceless-booth-2dfcaf ready!

Name Link
Latest commit a0e2dc8a897d420fcf74d8a2d3cf503b84c03b26
Latest deploy log https://app.netlify.com/sites/priceless-booth-2dfcaf/deploys/64bdb30816f01f0008492d8b
Deploy Preview https://deploy-preview-183--priceless-booth-2dfcaf.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cherylli commented 1 year ago

Where are we embedding the videos? And how do we view the page with the video?

LuSilvaDeveloper commented 1 year ago

According to the issue, it seems that testing the functionality of the embedded videos will be possible only after the pull request (PR) is merged and the changes are deployed and after that, using Liquid code. Liquid is a template language that allows us to display data in a template.

cherylli commented 1 year ago

looks good

@sergiobtos, I saw your previous comment which is now edited. Is it working for you now? This came across my mind at first but I did not do any testing.

sergiobtos commented 1 year ago

@cherylli no, I could not make it work in my code. I tried to implement it in my repo, with no success. Also, from that tutorial, I could not understand how he used _includes. Because the only place that I saw the iframe working was on GitHub pages with this url : https://codepo8.github.io/youtube-embed/demo.html . It shows demo.html, I am confused because it is not *.md or wiki.

mariana-caldas commented 1 year ago

Hey @cherylli and @sergiobtos !

Just to give you more context about our Wikipedia. It's a special repository formed by .md files that connects directly with GitHub. I encourage you to clone it locally to understand more about its structure.

In theory :), the _includes folder is a convention folder that talks to GitHub when placed on any project root. As @LuSilvaDeveloper mentioned, we will be able to test it properly once the new folder is part of the repository, which means after merging this PR. Feel free to reach out if you have further questions!

image

cherylli commented 1 year ago

Hey @cherylli and @sergiobtos !

Just to give you more context about our Wikipedia. It's a special repository formed by .md files that connects directly with GitHub. I encourage you to clone it locally to understand more about its structure.

In theory :), the _includes folder is a convention folder that talks to GitHub when placed on any project root. As @LuSilvaDeveloper mentioned, we will be able to test it properly once the new folder is part of the repository, which means after merging this PR. Feel free to reach out if you have further questions!

image

but is there a reason why this cannot be tested on a test repo before merging to production? Either way, it's not a critical part that would affect the site so happy for it to be tested after merging