Web-Dev-Path / web-dev-path

The Web Dev Path platform. Progressive Web App (PWA). Next.js rules!
https://webdevpath.co
GNU General Public License v3.0
33 stars 11 forks source link

Allow `BlogPostsContainer` display a dynamic number of cards per row with swipe #197

Closed mariana-caldas closed 1 year ago

mariana-caldas commented 1 year ago
Web Dev Path

Have you updated the CHANGELOG.md file? If not, please do it.

Yes

What is this change?

Were there any complications while making this change?

No.

How to replicate the issue?

  1. Check the blog page in prod. Under the section "Our Success Stories", you see the 4th card is in a second row due to a rule that set the rows would be formed by 3 posts.

Screen Shot 2023-09-11 at 4 04 39 PM

  1. When running this branch locally, that's the expected result on the desktop. Notice the swipe functionality indicates, even on the desktop, that there are more posts on that row.

Screen Shot 2023-09-11 at 4 05 16 PM

If necessary, please describe how to test the new feature or fix.

Check the point above.

When should this be merged?

After review

netlify[bot] commented 1 year ago

Deploy Preview for webdevpathstage ready!

Name Link
Latest commit d0a8d8888614e7f6a3e51181e0a4f0cdb2a7b090
Latest deploy log https://app.netlify.com/sites/webdevpathstage/deploys/6501f85f83ea9c0008fb54a9
Deploy Preview https://deploy-preview-197--webdevpathstage.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

LuSilvaDeveloper commented 1 year ago

It looks perfect. The blog page looks consistent with all the sections having the same behaviour. The swipe functionality makes it look more clean.

I'd like just to add a comment. Talking about the swipe functionality, should we have it on Latest Posts too? I think in that way everything will have the same look and feel on the Blog section.

Thank you @mariana-caldas!