Closed vmcodes closed 11 months ago
Name | Link |
---|---|
Latest commit | 45db4db396c95fd3117f715ee768cc3548975eaf |
Latest deploy log | https://app.netlify.com/sites/webdevpathstage/deploys/655d71fcf8673c0008038497 |
Deploy Preview | https://deploy-preview-207--webdevpathstage.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
I added SEO tags to the _documents.js head, but I think we should discuss the best keywords and relevant content for the site
Is there any way to see what it looks like on the search result with the preview site?
Is there any way to see what it looks like on the search result with the preview site?
@Satoshi-Sh Twitter used to have a pretty cool preview tool for Twitter cards, but unfortunately I'm not sure of any others at the moment. Also, since the the logo references aren't on the main branch yet, a preview wouldn't work since we reference the full path. That would be really useful though.
LGTM, thanks, @vmcodes !
@mariana-caldas no problem, any suggestions for the keys words and descriptions located in the _document.js head section?
LGTM, thanks, @vmcodes !
@mariana-caldas no problem, any suggestions for the keys words and descriptions located in the _document.js head section?
I've just created this issue to tackle that on Meta.js
-> https://github.com/Web-Dev-Path/web-dev-path/issues/208 . I wonder if that's enough or if we should use a similar approach of getting that data dynamically from meta.js
later to add the data dynamically according to the page router @Satoshi-Sh and @vmcodes
LGTM, thanks, @vmcodes !
@mariana-caldas no problem, any suggestions for the keys words and descriptions located in the _document.js head section?
I've just created this issue to tackle that on
Meta.js
-> #208 . I wonder if that's enough or if we should use a similar approach of getting that data dynamically frommeta.js
later to add the data dynamically according to the page router @Satoshi-Sh and @vmcodes
I actually asked chatGPT about the possible redundancy of adding meta tags both on _documents.js
and on Meta.js
and that was the answer. So I guess we can just move forward and work with dynamic data later on the #208 issue. Please let me know your thoughts!
LGTM, thanks, @vmcodes !
@mariana-caldas no problem, any suggestions for the keys words and descriptions located in the _document.js head section?
I've just created this issue to tackle that on
Meta.js
-> #208 . I wonder if that's enough or if we should use a similar approach of getting that data dynamically frommeta.js
later to add the data dynamically according to the page router @Satoshi-Sh and @vmcodesI actually asked chatGPT about the possible redundancy of adding meta tags both on
_documents.js
and onMeta.js
and that was the answer. So I guess we can just move forward and work with dynamic data later on the #208 issue. Please let me know your thoughts!
@mariana-caldas Ya I think just making them 2 separate issues would be good. The second just being an improvement on the initial issue. I don't think it would hurt to have it merged at the moment for now. I also added a canonical link, which would be good to have dynamically updated as well.
Let's see what will happen in production. Thanks for your work!!
Expect a delay in the images populating as far as the meta tags for social media go because they do occasionally take some time, but I think we'll be alright once they do.
Have you updated the CHANGELOG.md file? If not, please do it.
yes
What is this change?
updated robots.txt to allow Google to crawl site and added SEO tags
Were there any complications while making this change?
no
When should this be merged?
after review