search

Web-Ex-Machina / contao-offers

GNU Lesser General Public License v3.0
1 stars 1 forks source link

Field "file" clarification #8

Closed LupusVII closed 6 months ago

LupusVII commented 1 year ago

"This field allow every type of file. Tt's okay for a downlowdable text file like a pdf, but for pictures, sizing fields would be needed. We may want to have a slider of multiple pictures, like leboncoin ? if so, take the smartgear.fr's tabs/slider image configuration fields as reference"

@SeptimusVII Should we split this into two fields: pictures / files ? And make those fields not mandatory since not all kind of offers requires pictures nor files?

SeptimusVII commented 1 year ago

"This field allow every type of file. Tt's okay for a downlowdable text file like a pdf, but for pictures, sizing fields would be needed. We may want to have a slider of multiple pictures, like leboncoin ? if so, take the smartgear.fr's tabs/slider image configuration fields as reference"

@SeptimusVII Should we split this into two fields: pictures / files ? And make those fields not mandatory since not all kind of offers requires pictures nor files?

yes for spliting into two fields, not mandatory

create-issue-branch[bot] commented 1 year ago

Branch issue-8-Field_file_clarification created!

SeptimusVII commented 1 year ago

@LupusVII this issue does not look like it's resolved. Confusion between branches origin/issue-8-Field_file_clarification and origin/issue-6-Contao-backend may have been made, as origin/issue-6-Contao-backend seems to hold answers to this issue, but hasn't been merged image

LupusVII commented 6 months ago

Fixed with https://github.com/Web-Ex-Machina/contao-offers/releases/tag/2.0.0