Web-Feet / coasterframework

Main code repository for Coaster CMS (coastercms.org), a full featured Laravel based, Content Management System
https://www.coastercms.org
GNU General Public License v3.0
31 stars 22 forks source link

Admin "add content language" feature #58

Open neil-jennings opened 7 years ago

neil-jennings commented 7 years ago
SarajevoNo1 commented 7 years ago

Can you describe this modification a little bit closer ?!

chadanuk commented 7 years ago

@SarajevoNo1 We will add an ability to add multiple languages.

At the point that the language is added, the block content from an existing language can be copied across.

SarajevoNo1 commented 7 years ago

Yes this great to copy from another. :;)))

Get Outlook for Androidhttps://aka.ms/ghei36


From: Daniel Chadwick notifications@github.com Sent: Thursday, July 20, 2017 10:53:08 AM To: Web-Feet/coasterframework Cc: SarajevoNo1; Comment Subject: Re: [Web-Feet/coasterframework] Admin "add content language" feature (#58)

We will add an ability to add multiple languages.

At the point that the language is added, the block content from an existing language can be copied across.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/Web-Feet/coasterframework/issues/58#issuecomment-316640365, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AatkBVZ47y3fG7IjJ9VblhfKoIR2Mg1Mks5sPxV0gaJpZM4OUG0A.

SarajevoNo1 commented 7 years ago

Can we update something inside Sitemap (in code) when second language is added that google can crawl page on two languages for all links...etc...

What is need to be updated for this to have Sitemap and on other added languages...?!

Thanks

Get Outlook for Androidhttps://aka.ms/ghei36


From: tarik s tarik.personal@hotmail.com Sent: Thursday, July 20, 2017 3:48:31 PM To: Web-Feet/coasterframework; Web-Feet/coasterframework Cc: Comment Subject: Re: [Web-Feet/coasterframework] Admin "add content language" feature (#58)

Yes this great to copy from another. :;)))

Get Outlook for Androidhttps://aka.ms/ghei36


From: Daniel Chadwick notifications@github.com Sent: Thursday, July 20, 2017 10:53:08 AM To: Web-Feet/coasterframework Cc: SarajevoNo1; Comment Subject: Re: [Web-Feet/coasterframework] Admin "add content language" feature (#58)

We will add an ability to add multiple languages.

At the point that the language is added, the block content from an existing language can be copied across.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/Web-Feet/coasterframework/issues/58#issuecomment-316640365, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AatkBVZ47y3fG7IjJ9VblhfKoIR2Mg1Mks5sPxV0gaJpZM4OUG0A.

chadanuk commented 7 years ago

We'll bear that in mind. Good point.

neil-jennings commented 7 years ago

You could add a Lanuage::set() around the sitemap templates and run then for each language.

Will look at adding a setting to return all urls.

SarajevoNo1 commented 7 years ago

Hi Neil.. where this need to be added exactly: Lanuage::set()..

Can we update something inside Sitemap (in code) when second language is added that google can crawl page on two languages for all links...etc...

Can you write up the doc for lang switcher to be completly to have all urls inside sitemap...with this or update coastercms with needed changes..

Please let us know when find solution!

Thanks in advance

Tarik :;))))

Get Outlook for Androidhttps://aka.ms/ghei36


From: Neil Jennings notifications@github.com Sent: Monday, July 24, 2017 10:37:16 AM To: Web-Feet/coasterframework Cc: SarajevoNo1; Mention Subject: Re: [Web-Feet/coasterframework] Admin "add content language" feature (#58)

Reopened #58https://github.com/Web-Feet/coasterframework/issues/58.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Web-Feet/coasterframework/issues/58#event-1175688220, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AatkBaXWc1nGiuAUaVA4VeJ8cgRVDXKoks5sRFe8gaJpZM4OUG0A.

SarajevoNo1 commented 7 years ago

Hi Neil.

In which file I need to add this: Lanuage::set()

For sitemap to have sitemap on all languages.. do you change anything im the code fore updating sitemap when we have more than 1 language?!

Thanks

Get Outlook for Androidhttps://aka.ms/ghei36


From: tarik s tarik.personal@hotmail.com Sent: Monday, July 24, 2017 10:46:16 AM To: Web-Feet/coasterframework; Web-Feet/coasterframework Cc: Mention; Neil Jennings Subject: Re: [Web-Feet/coasterframework] Admin "add content language" feature (#58)

Hi Neil.. where this need to be added exactly: Lanuage::set()..

Can we update something inside Sitemap (in code) when second language is added that google can crawl page on two languages for all links...etc...

Can you write up the doc for lang switcher to be completly to have all urls inside sitemap...with this or update coastercms with needed changes..

Please let us know when find solution!

Thanks in advance

Tarik :;))))

Get Outlook for Androidhttps://aka.ms/ghei36


From: Neil Jennings notifications@github.com Sent: Monday, July 24, 2017 10:37:16 AM To: Web-Feet/coasterframework Cc: SarajevoNo1; Mention Subject: Re: [Web-Feet/coasterframework] Admin "add content language" feature (#58)

Reopened #58https://github.com/Web-Feet/coasterframework/issues/58.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Web-Feet/coasterframework/issues/58#event-1175688220, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AatkBaXWc1nGiuAUaVA4VeJ8cgRVDXKoks5sRFe8gaJpZM4OUG0A.

neil-jennings commented 7 years ago

templates/sitemap.blade.php

{!! PageBuilder::sitemap(['view' => 'sitemap']) !!} {{ Language::set($id) }} {!! PageBuilder::sitemap(['view' => 'sitemap']) !!}

may also have to alter the files in categories/sitemap/ to move the ul elements

SarajevoNo1 commented 7 years ago

Hi Neil,

Now I added this piece of code in sitemap.blade.php (PICTURE IN ATTACHMENT); and then I get this: lokom.croatiago.com/sitemap - (Picture in attachment sitemap)!!!

Did I add this in right way and what should else I need to add in what file to reproduce sitemap view on all languages....

sitemap blade php sitemap

SarajevoNo1 commented 7 years ago

Hi Neil,

Now I added this piece of code in sitemap.blade.php (PICTURE IN ATTACHMENT - sitemap.blade.php.jpg - first image); and then I get this: lokom.croatiago.com/sitemap - (Picture in attachment sitemap.jpg - second image)!!!

Did I add this in right way and what should else I need to add in what file to reproduce sitemap view on all languages....


Šalje: Neil Jennings notifications@github.com Poslano: 28. srpnja 2017. 10:10 Prima: Web-Feet/coasterframework Kopija: SarajevoNo1; Mention Predmet: Re: [Web-Feet/coasterframework] Admin "add content language" feature (#58)

templates/sitemap.blade.php

{!! PageBuilder::sitemap(['view' => 'sitemap']) !!} {{ Language::set($id) }} {!! PageBuilder::sitemap(['view' => 'sitemap']) !!}

may also have to alter the files in categories/sitemap/ to move the ul elements

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Web-Feet/coasterframework/issues/58#issuecomment-318589954, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AatkBRIbsTCwUK4Ze1X0mzoTfSAkhRl8ks5sSZdsgaJpZM4OUG0A.

neil-jennings commented 7 years ago

Forgot the namespace: \CoasterCms\Models\Laguange::set();

SarajevoNo1 commented 7 years ago

I have now in sitemap.blade.php this:

<?php namespace: CoasterCms\Models\Language::set();

An have this in middle of sitemap.blade.php

{!! PageBuilder::sitemap(['view' => 'sitemap']) !!} {{ Language::set($id) }} {!! PageBuilder::sitemap(['view' => 'sitemap']) !!}

But get this error again: http://lokom.croatiago.com/sitemap


Šalje: Neil Jennings notifications@github.com Poslano: 31. srpnja 2017. 10:29 Prima: Web-Feet/coasterframework Kopija: SarajevoNo1; Mention Predmet: Re: [Web-Feet/coasterframework] Admin "add content language" feature (#58)

Forgot the namespace: \CoasterCms\Models\Laguange::set();

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Web-Feet/coasterframework/issues/58#issuecomment-319002429, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AatkBWw0xl7QlnbKp5T_7R5lVREGbY-wks5sTZBkgaJpZM4OUG0A.

SarajevoNo1 commented 7 years ago

sitemap-error

neil-jennings commented 7 years ago

{!! PageBuilder::sitemap(['view' => 'sitemap']) !!} {{ \CoasterCms\Models\Laguange::set($id) }} {!! PageBuilder::sitemap(['view' => 'sitemap']) !!}

SarajevoNo1 commented 7 years ago

Hi Neil,

Now I have added this inside sitemap.blade.php like exactly like you said:

{!! PageBuilder::sitemap(['view' => 'sitemap']) !!} {{ \CoasterCms\Models\Language::set($id) }} {!! PageBuilder::sitemap(['view' => 'sitemap']) !!}

AND I GET THIS ERROR 500 NOW: http://lokom.croatiago.com/sitemap ; AND DONT SEE ANYTHING CHANGE HERE: http://lokom.croatiago.com/sitemap http://lokom.croatiago.com/sitemap.xml - and when i change to other language from lang switcher and try open /sitemap or /sitemap.xml I dont see anything for second language just error 404..you can try....

ERROR 500 I GET:

[cid:5a06376d-0513-4910-9d62-6347d0891b1c]

THANKS :) THANKS IN ADVANCE!!!!!!!!!


Šalje: Neil Jennings notifications@github.com Poslano: 1. kolovoza 2017. 15:35 Prima: Web-Feet/coasterframework Kopija: SarajevoNo1; Mention Predmet: Re: [Web-Feet/coasterframework] Admin "add content language" feature (#58)

{!! PageBuilder::sitemap(['view' => 'sitemap']) !!} {{ \CoasterCms\Models\Laguange::set($id) }} {!! PageBuilder::sitemap(['view' => 'sitemap']) !!}

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Web-Feet/coasterframework/issues/58#issuecomment-319371528, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AatkBThAx7WFkbpiDDNhTwoHrRme7QIdks5sTymNgaJpZM4OUG0A.

SarajevoNo1 commented 7 years ago

500error

chadanuk commented 7 years ago

Try @php \CoasterCms\Models\Laguange::set($id) @endphp

SarajevoNo1 commented 7 years ago

When I change $id with the 1 or 2 (number - language id), like this:

{!! PageBuilder::sitemap(['view' => 'sitemap']) !!} {{ \CoasterCms\Models\Language::set(2) }} {!! PageBuilder::sitemap(['view' => 'sitemap']) !!}

AGAIN it wont open sitemap for the second language (Bosnian) it shows error 404: http://lokom.croatiago.com/sitemap the same is for /sitemap.xml

Sitemap | Coaster CMShttp://lokom.croatiago.com/sitemap lokom.croatiago.com Sitemap

When switch to english lang it open sitemap for english but for second language bosnian it wont.... I try and Daniel suggestion too but it doesnt work...

What should I excatly add in here to get reliable generated sitemap...

THANKS IN ADVANCE !!!!!!!!!


Šalje: Daniel Chadwick notifications@github.com Poslano: 9. kolovoza 2017. 19:06 Prima: Web-Feet/coasterframework Kopija: SarajevoNo1; Mention Predmet: Re: [Web-Feet/coasterframework] Admin "add content language" feature (#58)

Try @phphttps://github.com/php \CoasterCms\Models\Laguange::set($id) @endphp

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Web-Feet/coasterframework/issues/58#issuecomment-321318865, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AatkBZn9q1_PkQYuKUmccYqHYkWdV1_9ks5sWecsgaJpZM4OUG0A.

SarajevoNo1 commented 7 years ago

Can you please add some explanation in the new documentation for language switcher - for sitemap when we add second language - to have this full resolved !


Šalje: tarik s tarik.personal@hotmail.com Poslano: 10. kolovoza 2017. 15:23 Prima: Web-Feet/coasterframework Predmet: SITEMAP DOESNT WORK !!!!!!!!!1

When I change $id with the 1 or 2 (number - language id), like this:

{!! PageBuilder::sitemap(['view' => 'sitemap']) !!} {{ \CoasterCms\Models\Language::set(2) }} {!! PageBuilder::sitemap(['view' => 'sitemap']) !!}

AGAIN it wont open sitemap for the second language (Bosnian) it shows error 404: http://lokom.croatiago.com/sitemap the same is for /sitemap.xml

Sitemap | Coaster CMShttp://lokom.croatiago.com/sitemap lokom.croatiago.com Sitemap

When switch to english lang it open sitemap for english but for second language bosnian it wont.... I try and Daniel suggestion too but it doesnt work...

What should I excatly add in here to get reliable generated sitemap...

THANKS IN ADVANCE !!!!!!!!!


Šalje: Daniel Chadwick notifications@github.com Poslano: 9. kolovoza 2017. 19:06 Prima: Web-Feet/coasterframework Kopija: SarajevoNo1; Mention Predmet: Re: [Web-Feet/coasterframework] Admin "add content language" feature (#58)

Try @phphttps://github.com/php \CoasterCms\Models\Laguange::set($id) @endphp

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Web-Feet/coasterframework/issues/58#issuecomment-321318865, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AatkBZn9q1_PkQYuKUmccYqHYkWdV1_9ks5sWecsgaJpZM4OUG0A.

tliesnham commented 7 years ago

Thanks for reporting this, it does look as though sitemaps are only working for the base language. We'll take a look into this as soon as possible, and will let you know when we've found a solution.

SarajevoNo1 commented 7 years ago

Thanks Taylor,

Yes maybe sitemap now only work for the base language. Please find some solution for the sitemap on all languages.

Thank you :))


Šalje: Taylor notifications@github.com Poslano: 10. kolovoza 2017. 15:40 Prima: Web-Feet/coasterframework Kopija: SarajevoNo1; Mention Predmet: Re: [Web-Feet/coasterframework] Admin "add content language" feature (#58)

Thanks for reporting this, it does look as though sitemaps are only working for the base language. We'll take a look into this as soon as possible, and will let you know when we've found a solution.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Web-Feet/coasterframework/issues/58#issuecomment-321553997, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AatkBWJQwQbvfcDwbryRKyDJgWqJuAz4ks5sWwhKgaJpZM4OUG0A.

SarajevoNo1 commented 7 years ago

Hi..

Are there any news about the sitemap solution when add additional language..

Thanks

Get Outlook for Androidhttps://aka.ms/ghei36


From: tarik s tarik.personal@hotmail.com Sent: Thursday, August 10, 2017 3:43:12 PM To: Web-Feet/coasterframework Subject: Re: [Web-Feet/coasterframework] Admin "add content language" feature (#58)

Thanks Taylor,

Yes maybe sitemap now only work for the base language. Please find some solution for the sitemap on all languages.

Thank you :))


Šalje: Taylor notifications@github.com Poslano: 10. kolovoza 2017. 15:40 Prima: Web-Feet/coasterframework Kopija: SarajevoNo1; Mention Predmet: Re: [Web-Feet/coasterframework] Admin "add content language" feature (#58)

Thanks for reporting this, it does look as though sitemaps are only working for the base language. We'll take a look into this as soon as possible, and will let you know when we've found a solution.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Web-Feet/coasterframework/issues/58#issuecomment-321553997, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AatkBWJQwQbvfcDwbryRKyDJgWqJuAz4ks5sWwhKgaJpZM4OUG0A.

SarajevoNo1 commented 7 years ago

Hi Taylor and Neil....

Are there any news about the sitemap solution when add (have new) additional language..

Thanks in advance Tarik

Get Outlook for Androidhttps://aka.ms/ghei36


From: tarik s tarik.personal@hotmail.com Sent: Friday, August 18, 2017 10:39:58 AM To: Web-Feet/coasterframework; Neil Jennings Subject: Re: [Web-Feet/coasterframework] Admin "add content language" feature (#58)

Hi..

Are there any news about the sitemap solution when add additional language..

Thanks

Get Outlook for Androidhttps://aka.ms/ghei36


From: tarik s tarik.personal@hotmail.com Sent: Thursday, August 10, 2017 3:43:12 PM To: Web-Feet/coasterframework Subject: Re: [Web-Feet/coasterframework] Admin "add content language" feature (#58)

Thanks Taylor,

Yes maybe sitemap now only work for the base language. Please find some solution for the sitemap on all languages.

Thank you :))


Šalje: Taylor notifications@github.com Poslano: 10. kolovoza 2017. 15:40 Prima: Web-Feet/coasterframework Kopija: SarajevoNo1; Mention Predmet: Re: [Web-Feet/coasterframework] Admin "add content language" feature (#58)

Thanks for reporting this, it does look as though sitemaps are only working for the base language. We'll take a look into this as soon as possible, and will let you know when we've found a solution.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Web-Feet/coasterframework/issues/58#issuecomment-321553997, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AatkBWJQwQbvfcDwbryRKyDJgWqJuAz4ks5sWwhKgaJpZM4OUG0A.

neil-jennings commented 7 years ago

Hi Tarik, We have no timescale for this at the moment. We will let you know when we build this in. Neil