Web-Multi-Media / multi-web-audio-sequencer

Web collaborative step sequencer
https://labs.freesound.org/sequencer
GNU General Public License v3.0
10 stars 2 forks source link

Load sequencer state when new user connect - Iss1 #3

Closed valou5940 closed 6 years ago

valou5940 commented 6 years ago

In the future, we should modify these fonction to dynamically activate the pads in case other tracks are created

Then I propose to open a new issue for adding tracks to the sequencer

DerouineauNicolas commented 6 years ago

Ok for me !

xavierfav commented 6 years ago

Please give a comprehensive title to the PR and reference the issue so that Github track it makes it easier to then follow the progression.

Reference the issue: #1

Also, please take a look at for instance this blog post: How to Write a Git Commit Message.

xavierfav commented 6 years ago

It's nice, good job!

A few comments:

DerouineauNicolas commented 6 years ago

The PR is merged. @xavierfav Should we address your comments in a different issue/branch ?