Web3Philippines / directory

Official Web3 Philippines Directory. 🚀
https://directory.web3philippines.org
GNU General Public License v3.0
18 stars 8 forks source link

📦 NEW: add react-query for data-management #18

Closed jnebab closed 2 years ago

jnebab commented 2 years ago
  1. added react-query and config for data management.
  2. implemented mocked data-fetching to use react-query
  3. added a separate interface file for types
  4. fixed directory mapping error on homepage
  5. fixed import error in project info page
  6. removed type checking plugin for ts lint config
  7. added Seo in project info page
kquirapas commented 2 years ago

Hindi ko malagyan ng suggestion kasi wala sa diff hunk

Pero line 47-48 of Card.tsx consider adding a "key" attribute to the list rendered project tags

        {project.tags.map((tag) => (
          <li className="rounded-sm bg-purple-heart px-2 py-1 lowercase text-white">
            {tag}
          </li>
        ))}

Do this

        {project.tags.map((tag, idx) => (
          <li key={idx} className="rounded-sm bg-purple-heart px-2 py-1 lowercase text-white">
            {tag}
          </li>
        ))}

Can you apply this change? @jnebab

jnebab commented 2 years ago

Hindi ko malagyan ng suggestion kasi wala sa diff hunk

Pero line 47-48 of Card.tsx consider adding a "key" attribute to the list rendered project tags

        {project.tags.map((tag) => (
          <li className="rounded-sm bg-purple-heart px-2 py-1 lowercase text-white">
            {tag}
          </li>
        ))}

Do this

        {project.tags.map((tag, idx) => (
          <li key={idx} className="rounded-sm bg-purple-heart px-2 py-1 lowercase text-white">
            {tag}
          </li>
        ))}

Can you apply this change? @jnebab

done na sir

kquirapas commented 2 years ago

Pwede na isabay dito yung attachment nung true api. @warengonzaga when are you planning to deploy? or deploy ako ng temporary?

In English Translation for Web 3 Philippines International Contributors:

jnebab commented 2 years ago

Pwede na isabay dito yung attachment nung true api. @warengonzaga when are you planning to deploy? or deploy ako ng temporary?

that might limit other devs to contribute though. ayuko naman ariin lahat ng gagawin hehe

kquirapas commented 2 years ago

Makes sense

warengonzaga commented 2 years ago

Pwede na isabay dito yung attachment nung true api. @warengonzaga when are you planning to deploy? or deploy ako ng temporary?

that might limit other devs to contribute though. ayuko naman ariin lahat ng gagawin hehe

Indeed, we must follow the milestone in the design docs. I'll merge this with mock data only. Let's add them on the next merge.

warengonzaga commented 2 years ago

hey, @jnebab let me know once you are done with the changes, basically, just replace project in the code base and replace with directory instead. Thank you for your help and contribution!

jnebab commented 2 years ago

Done @warengonzaga