Closed jnebab closed 2 years ago
Hindi ko malagyan ng suggestion kasi wala sa diff hunk
Pero line 47-48
of Card.tsx
consider adding a "key" attribute to the list rendered project tags
{project.tags.map((tag) => (
<li className="rounded-sm bg-purple-heart px-2 py-1 lowercase text-white">
{tag}
</li>
))}
Do this
{project.tags.map((tag, idx) => (
<li key={idx} className="rounded-sm bg-purple-heart px-2 py-1 lowercase text-white">
{tag}
</li>
))}
Can you apply this change? @jnebab
Hindi ko malagyan ng suggestion kasi wala sa diff hunk
Pero
line 47-48
ofCard.tsx
consider adding a "key" attribute to the list rendered project tags{project.tags.map((tag) => ( <li className="rounded-sm bg-purple-heart px-2 py-1 lowercase text-white"> {tag} </li> ))}
Do this
{project.tags.map((tag, idx) => ( <li key={idx} className="rounded-sm bg-purple-heart px-2 py-1 lowercase text-white"> {tag} </li> ))}
Can you apply this change? @jnebab
done na sir
Pwede na isabay dito yung attachment nung true api. @warengonzaga when are you planning to deploy? or deploy ako ng temporary?
In English Translation for Web 3 Philippines International Contributors:
Pwede na isabay dito yung attachment nung true api. @warengonzaga when are you planning to deploy? or deploy ako ng temporary?
that might limit other devs to contribute though. ayuko naman ariin lahat ng gagawin hehe
Makes sense
Pwede na isabay dito yung attachment nung true api. @warengonzaga when are you planning to deploy? or deploy ako ng temporary?
that might limit other devs to contribute though. ayuko naman ariin lahat ng gagawin hehe
Indeed, we must follow the milestone in the design docs. I'll merge this with mock data only. Let's add them on the next merge.
hey, @jnebab let me know once you are done with the changes, basically, just replace project
in the code base and replace with directory
instead. Thank you for your help and contribution!
Done @warengonzaga