search

Web3Philippines / directory

Official Web3 Philippines Directory. 🚀
https://directory.web3philippines.org
GNU General Public License v3.0
18 stars 8 forks source link

404 on card click (PandoProject) #34

Closed kquirapas closed 2 years ago

kquirapas commented 2 years ago

🤔 Not Existing Bug?

👀 Current Behavior

It's 404 on card click

🎯 Expected Behavior

Should redirect to entity site

📋 Steps To Reproduce

No response

📜 Code of Conduct

litchdoteth commented 2 years ago

@kquirapas maybe its because of the json file. PANDOPROJECT doesn't have any website indicated on the file

litchdoteth commented 2 years ago

same goes to Royal Labs

kquirapas commented 2 years ago

lets piggyback on next milestone @warengonzaga @itsnalla

litchdoteth commented 2 years ago

we need to standardize the form so that we can add their respective links. The required URL is the Project Website, if they don't have any maybe they can add their Twitter or Facebook. Additional and optional URL's are their socials, community, decks/whitepaper etc.

jnebab commented 2 years ago

I'll fix this on my next PR. i'll include all social links on a larger preview onCardClick so viewers can have other options if other links dont work. and I agree wth @itsnalla, we cant allow no links added during signup. whats the point of adding a project to the directory if no links to contact you. maybe, at least require website url and 1 social media link during signup

warengonzaga commented 2 years ago

Please tag this issue on any PR you made folks. 🤝 Thank you for reporting!

kquirapas commented 2 years ago

@itsnalla Kindly edit your comments (just like I did) to make it full english so our international contributors can easily contribute. Thank you!

litchdoteth commented 2 years ago

@itsnalla Kindly edit your comments (just like I did) to make it full english so our international contributors can easily contribute. Thank you!

edited thanks for correcting bro.

warengonzaga commented 2 years ago

Let's prioritize the fix for this thanks!

kquirapas commented 2 years ago

@jnebab @itsnalla fixing this on the api. I will either remove or change both RoyalLabs and PandoProject links

kquirapas commented 2 years ago

Resolved. https://github.com/web3phl/directory-api/pull/5

kquirapas commented 2 years ago

Will close on merge to main

warengonzaga commented 2 years ago

Closing this now as the issue fixed on the directory-api repo.