Web3Philippines / directory

Official Web3 Philippines Directory. 🚀
https://directory.web3philippines.org
GNU General Public License v3.0
18 stars 8 forks source link

📦 NEW: dark mode theme #62

Closed rgvillanueva28 closed 2 years ago

rgvillanueva28 commented 2 years ago

55

vercel[bot] commented 2 years ago

@rgvillanueva28 is attempting to deploy a commit to the Wareneutron Team on Vercel.

A member of the Team first needs to authorize it.

warengonzaga commented 2 years ago

Looks like has a few conflicts @rgvillanueva28 what branch did you use as base?

rgvillanueva28 commented 2 years ago

Used release/v1.3.0

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
directory ✅ Ready (Inspect) Visit Preview Sep 6, 2022 at 10:15AM (UTC)
warengonzaga commented 2 years ago

I was about to fix the PR @rgvillanueva28 but thank you! Let us review it first.

warengonzaga commented 2 years ago

Amazing work @rgvillanueva28! I like it, can we make the dark mode default? Then we can adjust the colors from there. cc: @jnebab @kquirapas

rgvillanueva28 commented 2 years ago

Yup. Dark mode by default is possible. Will update it soon.

kquirapas commented 2 years ago

Will Review

jnebab commented 2 years ago

Thanks for the contrib. Just have one minor issue in mobile. The position of the switch button is off. Kindly fix it. @rgvillanueva28

image

warengonzaga commented 2 years ago

fix mobile screen issue of the switch button and use matchMedia API to detect user's system preference and use it as the default theme

Actually agree with this we should follow the matchMedia API for user preference. Didn't think of it. Apologies @rgvillanueva28 🙏 I think that's our requirement for now. We can improve the colors once we merge this. cc: @jnebab

jnebab commented 2 years ago

fix mobile screen issue of the switch button and use matchMedia API to detect user's system preference and use it as the default theme

Actually agree with this we should follow the matchMedia API for user preference. Didn't think of it. Apologies @rgvillanueva28 🙏 I think that's our requirement for now. We can improve the colors once we merge this. cc: @jnebab

agreed!

warengonzaga commented 2 years ago

Alright looks like it is all good, I'm happy to merge it! Thanks, @jnebab, and @rgvillanueva28 for the contribution!