CSV Replace smart quotes when encoding is Windows-1252

WebApiContrib / WebAPIContrib.Core

Community Contributions for ASP.NET Core

MIT License

460 stars 116 forks source link

CSV Replace smart quotes when encoding is Windows-1252 #196

Closed mguinness closed 4 years ago

mguinness commented 4 years ago

For the CSV output formatter when the encoding is set to ISO-8859-1 smart quotes are translated to a regular quote which then doesn't get escaped in the output.

For example James “Mad Dog” Mattis is output as James "Mad Dog" Mattis instead of James ""Mad Dog"" Mattis.

damienbod commented 4 years ago

hi @mguinness

Thanks for the fix

I'll test this and create a new package when it's ok, will be a few days before I get to this.

Greetings Damien

mguinness commented 4 years ago

Thanks for merging, is it possible to publish a new version of WebApiContrib.Core.Formatter.Csv?

damienbod commented 4 years ago

@mguinness released, 3.0.1, sorry for the delay

Greetings Damien