WebAssembly / WASI

WebAssembly System Interface
Other
4.71k stars 240 forks source link

__wasm_call_dtors for reactors #593

Open SBKarr opened 3 months ago

SBKarr commented 3 months ago

Example usage model:

In current model, commands should not preserve state, it's one-call entities

Reactors can be initialised then called multiple times, but it's rely on root command for destructors. If we define dtors in reactor itself, it can broke command, that uses it.

For now, clang from wasi-sdk-21 (Rust too?) do not emits destructors code for reactor at all, only registers with __cxa_atexit. There should be a way to deinstantiate that type of module correctly. Maybe, some compiler flag on another exec model?

Upd: Ok, if i define some function, that calls __wasm_call_dtors directly, with -mexec-model=reactor it works as expected. Is it well-defined behavior? lld do not checks, that function is somehow exported, and can just strip it with '-Os', but leave __wasm_call_dtors in place.

sunfishcode commented 2 months ago

What kinds of cleanups does your code need to do? In some contexts, reactors are terminated abruptly by simply exiting the host process, which wouldn't give the Wasm code a chance to run any destructors. And if Wasm code traps, then it wouldn't be safe to re-enter it to call destructors for cleanups.

In WASIp2 with the component model, resources can have destructors that can automatically clean up external resources associated with handles, and that lets us clean up even in the case of abrupt exits such as traps.